[
https://issues.apache.org/jira/browse/OOZIE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489404#comment-16489404
]
Hadoop QA commented on OOZIE-3160:
----------------------------------
Testing JIRA OOZIE-3160
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [1] new bugs found below threshold in [core]
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important FindBugs errors are:
. At PriorityDelayQueue.java:[line 655]: Exceptional return value of
java.util.concurrent.locks.Condition.await(long, TimeUnit) ignored in
org.apache.oozie.util.PriorityDelayQueue.poll(long, TimeUnit)
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 2134
. Tests failed: 17
. Tests errors: 3
. The patch failed the following testcases:
testQueueUniquenessWithSameKeyInComposite(org.apache.oozie.service.TestCallableQueueService)
testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService)
testSerialConcurrencyLimit(org.apache.oozie.service.TestCallableQueueService)
testDelayedQueuing(org.apache.oozie.service.TestCallableQueueService)
testConcurrency(org.apache.oozie.service.TestCallableQueueService)
testCoordStatusTransitWithLock(org.apache.oozie.service.TestStatusTransitService)
testMultipleCoordSubmit(org.apache.oozie.command.bundle.TestBundleSubmitXCommand)
testEarlyCallbackTimeout(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testEarlyCallbackTransitionToRunning(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testBundleSuspend2(org.apache.oozie.command.bundle.TestBundleJobSuspendXCommand)
testStartTransient(org.apache.oozie.command.wf.TestActionErrors)
testEndTransient(org.apache.oozie.command.wf.TestActionErrors)
testDoneFlagCreation(org.apache.oozie.TestCoordinatorEngine)
testEmptyDoneFlag(org.apache.oozie.TestCoordinatorEngine)
testCustomDoneFlag(org.apache.oozie.TestCoordinatorEngine)
testDoneFlag(org.apache.oozie.TestCoordinatorEngine)
testUserRetryPolicy(org.apache.oozie.command.wf.TestActionUserRetry)
. Tests failing with errors:
testInfoWithBundle(org.apache.oozie.action.hadoop.TestOozieJobInfo)
testReRunRefresh(org.apache.oozie.command.coord.TestCoordUpdateXCommand)
testCoordinatorActionCommandsSubmitAndStart(org.apache.oozie.sla.TestSLAEventGeneration)
. {color:orange}Tests failed at first run:{color}
TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone
TestPastActionsTimeOut#testEngine
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:red}-1 DISTRO{color}
. {color:red}-1{color} distro tarball fails with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/569/
> PriorityDelayQueue put()/take() can cause significant CPU load due to busy
> waiting
> ----------------------------------------------------------------------------------
>
> Key: OOZIE-3160
> URL: https://issues.apache.org/jira/browse/OOZIE-3160
> Project: Oozie
> Issue Type: Bug
> Components: core
> Environment: all platforms
> Reporter: jj
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: 11111111111111.png, 222222222222222222.png,
> OOZIE-3160-POC01.patch
>
>
> oozie process always consume high cpu. in my mechine,around 10%.
> I check the source code，find take() method in PriorityDelayQueue class。
> code:
> {code:java}
> public QueueElement<E> take() throws InterruptedException {
> QueueElement<E> e = poll();
> while (e == null) {
> Thread.sleep(10);
> e = poll();
> }
> return e;
> }
> {code}
> i think it's the reason of this problem. it's keep while, not await.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
