----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67314/#review203872 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 97 (patched) <https://reviews.apache.org/r/67314/#comment286220> I'd at most log at `TRACE` level here. But I'd rather leave that and log at `DEBUG` level the resulting `argList` that's gonna be forwarded to `setSqoopCommand()`. core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 100 (patched) <https://reviews.apache.org/r/67314/#comment286221> I'd at most log at `TRACE` level here. But I'd rather leave that and log at `DEBUG` level the resulting `argList` that's gonna be forwarded to `setSqoopCommand()`. core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 105 (patched) <https://reviews.apache.org/r/67314/#comment286222> Don't we want to replace all `\n\n`s? core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 108 (patched) <https://reviews.apache.org/r/67314/#comment286223> `arrayLength` isn't a nice name for a variable that's incremented in a loop. sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java Line 46 (original), 46 (patched) <https://reviews.apache.org/r/67314/#comment286225> Please cover old functionality that uses `"\n"` as word separator inside the query, and new functionality that user `" "` as word separator inside the query, as well. Please also test a mixed case that uses both separators inside the same query. sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java Lines 50 (patched) <https://reviews.apache.org/r/67314/#comment286224> `SQOOP_QUERY_COMMAND` - András Piros On May 25, 2018, 7:37 a.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67314/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 7:37 a.m.) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-3218 > https://issues.apache.org/jira/browse/OOZIE-3218 > > > Repository: oozie-git > > > Description > ------- > > When running a Oozie Sqoop action which has command with --query in place the > query is split into multiple parts causing "Unrecognized argument:" and > in-turn fails. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 69d5e7e > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > edfe0c7 > > > Diff: https://reviews.apache.org/r/67314/diff/1/ > > > Testing > ------- > > > Thanks, > > Denes Bodo > >
