[
https://issues.apache.org/jira/browse/OOZIE-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496518#comment-16496518
]
TIAN XING commented on OOZIE-3156:
----------------------------------
Hey [~andras.piros], thanks for the review.
In \{{TestSshActionExecutor#testSshCheckWithHostConnectFailure()}}, I copy the
code from \{{TestSshActionExecutor#testJobStart}} which gives us an example
ends with OK status. In oder to create a "SSH connection failure" situation, I
changed action's \{{TrackerUri}} from "\{{<user>@localhost}}" to
"\{{dummy@dummyHost}}" during action status check. An exception is expected to
be thrown out, while before this patch, the check method will execute normally
and end with OK status.
Do you have any better suggestions on how to design such test case? Thanks!
> SSH action status turns OK wrongly when failed to connect to host
> -----------------------------------------------------------------
>
> Key: OOZIE-3156
> URL: https://issues.apache.org/jira/browse/OOZIE-3156
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 5.0.0
> Reporter: TIAN XING
> Assignee: TIAN XING
> Priority: Major
> Attachments: OOZIE-3156-v1.patch, OOZIE-3156-v2.patch,
> OOZIE-3156-v3.patch, ssh-check-bug.patch
>
>
> When {{check()}} method of {{SshActionExecutor}} gets invoked, oozie will ssh
> connect to the host and check whether the pid of the process that ssh action
> started is still there (by checking the returned value of command "{{ssh
> <host-ip> ps -p <pid>}}" ) to determine whether ssh action completes or not.
> However, we found cases where oozie fails to connect to host during action
> status check (e.g., the host is under heavy load, or network is bad etc.).
> In such cases, the return value of command "{{ssh <host-ip> ps -p <pid>}}"
> will be 255 (ssh command exits with the exit status of the remote command or
> with 255 if an error occurred.).
> According the current logic of method {{getActionStatus()}} in
> {{SshActionExecutor}}, the action status will be determined as OK which may
> not be correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
