----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57801/#review204181 -----------------------------------------------------------
Ship it! Ship It! - András Piros On June 1, 2018, 11:45 a.m., Jan Hentschel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57801/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 11:45 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2097 > https://issues.apache.org/jira/browse/OOZIE-2097 > > > Repository: oozie-git > > > Description > ------- > > Removed the non-Javadoc comments throughout the codebase. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleEngine.java 5c70b2ec > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 0a4703e7 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1fe3c637 > core/src/main/java/org/apache/oozie/DagEngine.java bb166d44 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java > 9260d83f > core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java > 8fc03b8a > core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java > 8f3b09fa > core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java 94a4f3a5 > core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java > 44fec542 > > core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java > bf1221d7 > core/src/main/java/org/apache/oozie/command/PauseTransitionXCommand.java > c2d9f838 > core/src/main/java/org/apache/oozie/command/PurgeXCommand.java 166c236f > core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java > 94bafa58 > core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java > 0e40dc1a > core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java > 9f85e1f6 > core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java > 9a4e5865 > core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java > d64e55ff > core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 6024138a > core/src/main/java/org/apache/oozie/command/UnpauseTransitionXCommand.java > 1dfd3b59 > core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java > d405ccb6 > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 5c9251a8 > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > e2bd69f8 > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 5c3d84ec > core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java > e11eea02 > core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java > 09dbdf6a > core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java > de61e5cf > core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 4cd175bc > core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > cc98a6db > > core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > dff22236 > > core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java > f3833164 > core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java > e0ccd0f2 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 6b849ee6 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java > 012fccb1 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 958194da > > core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > ef49ea58 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java > d4c98c80 > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 3b7b6645 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > fcc86a81 > core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java > ab511004 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 92e0dabd > core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java > 985b7a62 > core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > f1509e61 > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 2226b462 > core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java > a651f27e > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > 8536ed96 > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > ab40c6ee > core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 7e328b79 > core/src/main/java/org/apache/oozie/command/wf/BulkWorkflowXCommand.java > 4e0b6067 > core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java > 26397e0c > core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 3b6cb358 > core/src/main/java/org/apache/oozie/command/wf/JobsXCommand.java 29ac8ad9 > core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 178ae278 > core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java > 98d0f3cc > > core/src/main/java/org/apache/oozie/command/wf/WorkflowActionInfoXCommand.java > 895d549a > > core/src/main/java/org/apache/oozie/executor/jpa/BundleActionGetJPAExecutor.java > 3701a3e1 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleActionInsertJPAExecutor.java > 02522a16 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetCoordinatorsJPAExecutor.java > 579cd5c2 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java > e14f8aef > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetJPAExecutor.java > 14699e31 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java > f4fe0ef9 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInsertJPAExecutor.java > cb253f11 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java > c651d859 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java > f986c224 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java > bfb0b84e > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java > 7e217b44 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java > 31c4715d > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java > a9cf0ff3 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java > 2023678f > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java > a2a846ea > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java > ba309eb1 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java > 864ee63c > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionInsertJPAExecutor.java > eb061c25 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java > bedff49a > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteJPAExecutor.java > 8dd20cc2 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java > b444f054 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java > 68c0b758 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetJPAExecutor.java > 7dd3597f > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInsertJPAExecutor.java > 1af83d94 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java > 15d56f91 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java > cbebef3a > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java > 13e270bf > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java > 08781ad5 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java > 6d13ed17 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java > 5520ab5e > > core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java > 1f2c6889 > > core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java > bda1e489 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionDeleteJPAExecutor.java > 14dc45d4 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java > f8ac11e0 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionInsertJPAExecutor.java > f52af61e > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java > 606c9b75 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java > 6647a99d > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java > c333c0f6 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowIdGetForExternalIdJPAExecutor.java > c077cd83 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java > 5f12b4d7 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobDeleteJPAExecutor.java > 6623f028 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java > 58890d17 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetJPAExecutor.java > 2f7f17c6 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobInsertJPAExecutor.java > 84162879 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java > 8674aa2c > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java > 3e33c018 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java > f50c1a49 > core/src/main/java/org/apache/oozie/jms/MessageReceiver.java 87d0c5e7 > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > 7b899646 > core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java b43ab99f > core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java fc3a6bc1 > core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 9ecad01b > core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java > 42ce6adc > core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > bd41d03b > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java > 86c437cc > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java > 39bbee4b > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java > 3b72ecdf > > > Diff: https://reviews.apache.org/r/57801/diff/2/ > > > Testing > ------- > > > Thanks, > > Jan Hentschel > >
