[
https://issues.apache.org/jira/browse/OOZIE-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502011#comment-16502011
]
Peter Bacsko commented on OOZIE-2877:
-------------------------------------
I just have a question regarding this change:
{noformat}
+ final String repoUrl = "https://github.com/apache/oozie";;
+ final String keyUrl = "this_would_be_an_HDFS_path";
+ final String destDir = "repoDir";
+ final String branch = "myBranch";
+ Element actionXml = XmlUtils.parseXml("<git>" +
+ "<resource-manager>" + getJobTrackerUri() +
"</resource-manager>" +
+ "<name-node>" + getNameNodeUri() + "</name-node>" +
+ "<git-uri>" + repoUrl + "</git-uri>"+
+ "<branch>" + branch + "</branch>"+
+ "<key-path>" + keyUrl + "</key-path>"+
+ "<destination-uri>" + destDir + "</destination-uri>" +
+ "</git>");
{noformat}
Do I understand correctly that this would fetch a repository during the
integration test? If so, I'm really not sure that this is a good idea. Can't we
do it differently? I have two ideas:
1. Separately test {{GitMain}} with unit tests and somehow mock it during
{{TestGitActionExecutor}}
2. Start our own SSH server and simulate the execution of Git command
#1 seems to be easier.
> Oozie Git Action
> ----------------
>
> Key: OOZIE-2877
> URL: https://issues.apache.org/jira/browse/OOZIE-2877
> Project: Oozie
> Issue Type: Sub-task
> Components: action
> Reporter: Clay B.
> Assignee: Clay B.
> Priority: Major
> Labels: action
> Fix For: trunk
>
> Attachments: 0001-OOZIE-2877-Oozie-Git-Action.patch,
> 0002-OOZIE-2877-Oozie-Git-Action.patch,
> 0003-OOZIE-2877-Oozie-Git-Action.patch,
> 0004-OOZIE-2877-Oozie-Git-Action.patch,
> 0005-OOZIE-2877-Oozie-Git-Action.patch,
> 0006-OOZIE-2877-Oozie-Git-Action.patch,
> 0007-OOZIE-2877-Oozie-Git-Action.patch,
> 0008-OOZIE-2877-Oozie-Git-Action.patch,
> 0009-OOZIE-2877-Oozie-Git-Action.patch, OOZIE-2877.010.patch,
> OOZIE-2877.011.patch, OOZIE-2877.012.patch
>
>
> To aide in deploying ASCII artifacts to clusters, let's provide a tie-in for
> a source-code management system. Git would be my preferred choice.
> Ideally, this could handle a user's key material e.g. for an ssh key to pull
> down from a secured repository. This would free users from handling their own
> key staging and clean-up on YARN nodes and only require them to store the key
> secured in HDFS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
