[
https://issues.apache.org/jira/browse/OOZIE-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516835#comment-16516835
]
Andras Piros edited comment on OOZIE-3270 at 6/19/18 9:07 AM:
--------------------------------------------------------------
Thanks for the contribution [~gezapeti]! The patch looks good, I really like
the way you did a bit of test code cleanup and consolidation as well.
A few thoughts:
* please fix remaining {{FINDBUGS_DIFF}} and {{COMPILE}} problems from latest
pre-commit build run
* nit: {{TestOozieDBCLI:229-232}} could be extracted to
{{LauncherSecurityManager#checkAndLogExitCode()}} and be reused a couple of
times
* {{AllowAllPolicy}} could be tested to allow for a basic understanding on its
usage
* {{AG_ActionConfiguration.twiki}} or {{AG_Install.twiki}} could be extended
to have a better understanding on security aspects of {{LauncherAM}}
was (Author: andras.piros):
Thanks for the contribution [~gezapeti]! The patch looks good, I really like
the way you did a bit of test code cleanup and consolidation as well.
A few thoughts:
* please fix remaining {{FINDBUGS_DIFF}} and {{COMPILE]}} problems from latest
pre-commit build run
* nit: {{TestOozieDBCLI:229-232}} could be extracted to
{{LauncherSecurityManager#checkAndLogExitCode()}} and be reused a couple of
times
* {{AllowAllPolicy}} could be tested to allow for a basic understanding on its
usage
* {{AG_ActionConfiguration.twiki}} or {{AG_Install.twiki}} could be extended to
have a better understanding on security aspects of {{LauncherAM}}
> Upgrade Derby to 10.14.1.0
> ---------------------------
>
> Key: OOZIE-3270
> URL: https://issues.apache.org/jira/browse/OOZIE-3270
> Project: Oozie
> Issue Type: Improvement
> Reporter: Peter Cseh
> Assignee: Peter Cseh
> Priority: Major
> Attachments: OOZIE-3270.01.patch, OOZIE-3270.02.patch,
> OOZIE-3270.03.patch
>
>
> We should upgrade Derby to 10.14.1.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
