----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67763/#review205502 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java Line 122 (original), 125 (patched) <https://reviews.apache.org/r/67763/#comment288409> Can you please mark these places with `@SuppressFBWarnings(value, justification)` just like [here](https://github.com/apache/oozie/blob/master/client/src/main/java/org/apache/oozie/cli/OozieCLI.java#L1415-L1435)? core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java Line 525 (original), 522 (patched) <https://reviews.apache.org/r/67763/#comment288410> Can you please mark these places with `@SuppressFBWarnings(value, justification)` just like [here](https://github.com/apache/oozie/blob/master/client/src/main/java/org/apache/oozie/cli/OozieCLI.java#L1415-L1435)? - András Piros On June 27, 2018, 6:47 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67763/ > ----------------------------------------------------------- > > (Updated June 27, 2018, 6:47 p.m.) > > > Review request for oozie and András Piros. > > > Repository: oozie-git > > > Description > ------- > > Currently Findbugs complains about the a few warnings related to the reliance > on the default encoding in the oozie-core module > They should be fixed to get the code more reliable. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/StringBlob.java 6c776011 > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 919509d3 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java > 21c9b7e4 > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > d0b80742 > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 69d5e7e9 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 128feee7 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 80e7d5d4 > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 8bfa634f > core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java > 502a800f > core/src/main/java/org/apache/oozie/service/AuthorizationService.java > 251838ce > core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > c725f493 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 361141b0 > core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 36a9de22 > core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 4fc8f572 > core/src/main/java/org/apache/oozie/util/IOUtils.java 3674dc48 > core/src/main/java/org/apache/oozie/util/MultiFileReader.java 1ab5a7af > core/src/main/java/org/apache/oozie/util/XConfiguration.java e3591db3 > core/src/main/java/org/apache/oozie/util/XmlUtils.java 9db46b36 > > > Diff: https://reviews.apache.org/r/67763/diff/1/ > > > Testing > ------- > > > Thanks, > > Kinga Marton > >
