> On July 30, 2018, 10:46 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java > > Lines 60-61 (patched) > > <https://reviews.apache.org/r/68102/diff/1/?file=2065131#file2065131line60> > > > > Isn't emitting another message also just after sleep a good idea?
I have added a wake up message as well :) > On July 30, 2018, 10:46 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > > Lines 555-574 (patched) > > <https://reviews.apache.org/r/68102/diff/1/?file=2065132#file2065132line588> > > > > Please extract to `private static class ApplicationIdExistsPredicate > > implements Predicate<Boolean>`. I have extracted only the part performing the check. > On July 30, 2018, 10:46 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > > Lines 708-712 (patched) > > <https://reviews.apache.org/r/68102/diff/1/?file=2065132#file2065132line774> > > > > Please use latest schema version `1.0`. > > Peter Cseh wrote: > I don't think we should give up test coverage for older schemas. We > should keep around the old ones in test and make sure to add enough covergave > for new schemas when we add them. I can change here to the new schema, since there are some similar workflows using the old schema. - Kinga ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/#review206592 ----------------------------------------------------------- On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68102/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2018, 9:59 a.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > Tags were not generated properly for external child jobs launched from subWFs > and they were not killed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > a1a9671ab > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > fdca5706e > > core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > e074d482f > > > Diff: https://reviews.apache.org/r/68102/diff/2/ > > > Testing > ------- > > Tested manually. > Added Junit test. > > > Thanks, > > Kinga Marton > >
