----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67999/#review206798 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/service/TestShareLibService.java Lines 1045-1048 (patched) <https://reviews.apache.org/r/67999/#comment289877> Two big problems: 1. These have no effect on the test - the exception will be thrown on a different thread. You have to set a variable which gets examined later. 2. You don't wait for the threads to finish. - Peter Bacsko On júl. 20, 2018, 11 de, Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67999/ > ----------------------------------------------------------- > > (Updated júl. 20, 2018, 11 de) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-3304 > https://issues.apache.org/jira/browse/OOZIE-3304 > > > Repository: oozie-git > > > Description > ------- > > In rare cases the fNumberFormatException occurs while parsing latest sharelib > directory names > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > 5087505 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > d244166 > > > Diff: https://reviews.apache.org/r/67999/diff/1/ > > > Testing > ------- > > > Thanks, > > Denes Bodo > >
