> On Aug. 13, 2018, 12:28 p.m., Peter Cseh wrote: > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopMain.java > > Lines 66-68 (patched) > > <https://reviews.apache.org/r/68317/diff/1/?file=2071868#file2071868line66> > > > > Please put this into a finally or @after block so the cleanup happens > > even if the test fails
Finally block is a good idea and I think it is better here than the @After or overriden tearDown method. - Denes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68317/#review207151 ----------------------------------------------------------- On Aug. 13, 2018, 1:04 p.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68317/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2018, 1:04 p.m.) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-3326 > https://issues.apache.org/jira/browse/OOZIE-3326 > > > Repository: oozie-git > > > Description > ------- > > SqoopMain needs to support tez delegation tokens for hive-imports. > Implementation is similar to that of HiveMain and Hive2Main. > > At present, hive-import will fail to start a tez session in secure > environment. > > > Diffs > ----- > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > 4a41941 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > e6e182c > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/SystemEnvironment.java > PRE-CREATION > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > 27f9306 > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopMain.java > d6f96d5 > > > Diff: https://reviews.apache.org/r/68317/diff/2/ > > > Testing > ------- > > > Thanks, > > Denes Bodo > >
