[ 
https://issues.apache.org/jira/browse/OOZIE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578501#comment-16578501
 ] 

Andras Piros commented on OOZIE-3298:
-------------------------------------

Patch 005 addresses following:
* {{JavaActionExecutor#findYarnApplicationId()}} contains the original 
implementation only
* {{MapReduceActionExecutor#findYarnApplication()}} contains the modified 
implementation in three stages:
** based on {{action-data.seq}} written by {{MapReduceMain}}, if already present
** if not found, look up the appropriate YARN child ID
** if not found, go with {{WorkflowAction#getExternalId()}}
* new functionality is extracted into the nested classes 
{{MapReduceActionExecutor$HadoopJobIdFinder}} and 
{{MapReduceActionExecutor$YarnApplicationIdFinder}} for better readability, 
single responsibility, and testability
* {{TestYarnApplicationIdFinder}} covers important parts of the new 
functionality

Tested both using JUnit and on a real cluster, the patch now looks promising. 
[~pbacsko] [~asasvari] can you please review? Thanks!

> OYA: external ID is not filled properly and failing MR job is treated as 
> SUCCEEDED
> ----------------------------------------------------------------------------------
>
>                 Key: OOZIE-3298
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3298
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: Peter Bacsko
>            Assignee: Andras Piros
>            Priority: Blocker
>             Fix For: 5.1.0
>
>         Attachments: OOZIE-3298.001.patch, OOZIE-3298.002.patch, 
> OOZIE-3298.003.patch, OOZIE-3298.004.patch, OOZIE-3298.005.patch
>
>
> When a MapReduce action is launched from Oozie (OYA), we don't properly fill 
> the external ID field. It gets populated with the YARN id of the LauncherAM, 
> not with the id of the actual MR job. If the MR job is succesfully submitted 
> then fails, it will be treated as a successfully executed action, which is 
> very misleading and can potentially confuse Oozie users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to