-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68467/
-----------------------------------------------------------
(Updated Aug. 27, 2018, 11:35 a.m.)
Review request for oozie, András Piros and Andras Salamon.
Changes
-------
addressed FindBugs issues
Bugs: OOZIE-2684
https://issues.apache.org/jira/browse/OOZIE-2684
Repository: oozie-git
Description
-------
In SchemaCheckerService, Oozie compares expected and found indexed columns and
generates the below error message which could be confusing to the users.
`2016-09-16 12:39:26,564 INFO SchemaCheckXCommand:520 -
SERVER[c6402.ambari.apache.org] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-]
ACTION[-] About to check database schema`
`2016-09-16 12:39:26,703 ERROR SchemaCheckXCommand:517 -
SERVER[c6402.ambari.apache.org] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-]
ACTION[-] Found [1] extra indexes for columns in table [WF_ACTIONS]: [wf_id]`
`2016-09-16 12:39:26,723 ERROR SchemaCheckXCommand:517 -
SERVER[c6402.ambari.apache.org] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-]
ACTION[-] Database schema is BAD! Check previous error log messages for details`
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java 521408ee
core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java PRE-CREATION
core/src/test/java/org/apache/oozie/util/db/TestCompositeIndex.java
PRE-CREATION
tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java eeaaa60c
tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java cf3427f3
Diff: https://reviews.apache.org/r/68467/diff/3/
Changes: https://reviews.apache.org/r/68467/diff/2-3/
Testing
-------
Tested manually with MySql and PostgreSql.
I will open another Jira for making this part of code more testable, since now
is quite difficult to write some tests for it.
Thanks,
Kinga Marton
