-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68505/
-----------------------------------------------------------

(Updated Aug. 30, 2018, 6:42 p.m.)


Review request for oozie, Andras Salamon, Clay B., Peter Cseh, Kinga Marton, 
and Peter Bacsko.


Changes
-------

Addressing review comments.


Repository: oozie-git


Description
-------

OOZIE-2877 Git action


Diffs (updated)
-----

  client/src/main/resources/git-action-1.0.xsd PRE-CREATION 
  core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java 
PRE-CREATION 
  core/src/main/resources/oozie-default.xml 
b69d2c9aacc1a7f5f903fb80f77bbf5482feb3b5 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 
661970d57ac038d7311856a93f5221f081e9ce15 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 
76cbe21ecd79eae86885a8db77831bf2c40f2d4f 
  examples/src/main/apps/git/job.properties PRE-CREATION 
  examples/src/main/apps/git/workflow.xml PRE-CREATION 
  examples/src/main/java/org/apache/oozie/example/fluentjob/Git.java 
PRE-CREATION 
  fluent-job/fluent-job-api/pom.xml cefd43c143550a24ffba5a1d6922b8241dd5756a 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/action/GitAction.java
 PRE-CREATION 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/action/GitActionBuilder.java
 PRE-CREATION 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/DistcpConfigurationConverter.java
 fffb734e7c1b920e94f76e6a2b3062dd5aa73a86 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/ExplicitNodeConverter.java
 7bb82e5cbbffbee02785361eb2bbde2fc1c31e7a 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/GitConfigurationConverter.java
 PRE-CREATION 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/GitPrepareConverter.java
 PRE-CREATION 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/Hive2ConfigurationConverter.java
 c67b5aeab41e0c2d963c0ad3cf44fd19fe7c66e3 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/HiveConfigurationConverter.java
 5f9a2b180623b89c793e8e6bb6e03d445c0ad991 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/InlineWorkflowConfigurationConverter.java
 b1e17c9b5b8c29a81792ebfc637a53564bdb60fe 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/ShellConfigurationConverter.java
 ab73dfd2f24cbbfa60a37d75e5057f3ff2a1c0fa 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/SparkConfigurationConverter.java
 8827769ea84f8f08a79e5e2d0189e2d1ded4bd9d 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/SqoopConfigurationConverter.java
 1d4f615af583f8b941e570f3e3f239979cc8f825 
  
fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/serialization/WorkflowMarshaller.java
 ec56554ba4cd313a9d5ab8472ab3c62b6bc17380 
  fluent-job/fluent-job-api/src/main/resources/action_mappings.xml 
a5f890eef9ccc352a5a852781f4212d96913e6d2 
  fluent-job/fluent-job-api/src/main/xjb/bindings.xml 
48f68905ac2df2818d88907b26e863326d6d2c61 
  
fluent-job/fluent-job-client/src/test/java/org/apache/oozie/jobs/client/minitest/TestGitAction.java
 PRE-CREATION 
  pom.xml e0dbe85e5238fdc11cbd44cc31f65fc768c7454d 
  sharelib/git/pom.xml PRE-CREATION 
  sharelib/git/src/main/java/org/apache/oozie/action/hadoop/GitMain.java 
PRE-CREATION 
  sharelib/git/src/main/java/org/apache/oozie/action/hadoop/GitOperations.java 
PRE-CREATION 
  sharelib/git/src/test/java/org/apache/oozie/action/hadoop/GitServer.java 
PRE-CREATION 
  
sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestGitActionExecutor.java
 PRE-CREATION 
  sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestGitMain.java 
PRE-CREATION 
  
sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestIntegrationGitActionExecutor.java
 PRE-CREATION 
  sharelib/pom.xml 39cea257e750eb8b3f3c4cb3f137093fccc03016 
  src/main/assemblies/sharelib.xml 07dc69c8276895b254e5af0cc021cce6ebad18f4 
  webapp/pom.xml fd3f89feedd76657f1431898a268298549826d6f 


Diff: https://reviews.apache.org/r/68505/diff/2/

Changes: https://reviews.apache.org/r/68505/diff/1-2/


Testing
-------

Multiple unit and integration tests, as well as tests performed on a local 
Oozie server w/ pseudo-distributed Hadoop.

Based on the work Clay B. has done in previous patchsets till 
[OOZIE-2877.014-3.patch](https://issues.apache.org/jira/secure/attachment/12934336/OOZIE-2877.014-3.patch).


Thanks,

András Piros

Reply via email to