[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598607#comment-16598607
]
Andras Piros commented on OOZIE-3061:
-------------------------------------
[~matijhs] as I see the patch 005 consists of following parts:
# refactoring {{JavaActionExecutor#kill()}} - doesn't need any new tests
# extending {{LauncherMain#killChildYarnJobs()}} - definitely needs new tests
in {{TestLauncherMain}}
Apart from testing perspective, could you please modify the condition in
{{LauncherMain#killChildYarnJobs():265}} so that instead of getting only the
{{ApplicationReport}} in {{FinalApplicationStatus.UNDEFINED}}, we instead get
the one that is not {{SUCCEED}}, {{FAILED}}, or {{KILLED}}? So that we can stay
future proof just in case someone extends {{FinalApplicationStatus}} with a new
field.
> Kill only those child jobs which are not already killed
> -------------------------------------------------------
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 4.3.0
> Reporter: Satish Subhashrao Saley
> Assignee: Mate Juhasz
> Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.1.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
