----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69250/#review210324 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java Lines 283 (patched) <https://reviews.apache.org/r/69250/#comment294986> Probably it will never throw an Exception, but catching NumberFormatException and failing seems a bit nicer. - Andras Salamon On Nov. 5, 2018, 11:58 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69250/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2018, 11:58 a.m.) > > > Review request for oozie, Peter Cseh and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3376 [tests] TestGraphGenerator should assume JDK8 minor version at > least 1.8.0_u40 > > > Diffs > ----- > > core/src/main/resources/oozie-log4j.properties > ba8d7b9eac64970b6ad33256eb32b4d2a2819f9f > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > 9b0e263bf2d9fb796bc26d50d16f72237c24baad > docs/src/site/markdown/WebServicesAPI.md > 7cf62e5416c8198f5d3871d0adb812a10fc02011 > > > Diff: https://reviews.apache.org/r/69250/diff/1/ > > > Testing > ------- > > `TestGraphGenerator` methods modified. > > > Thanks, > > András Piros > >
