> On 十一月 28, 2018, 2:23 p.m., András Piros wrote: > >
Hello , I have submit the oozie-3379-7.patch. Please review it. Thanks - zhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69330/#review210926 ----------------------------------------------------------- On 十二月 4, 2018, 5:29 p.m., zhang junfan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69330/ > ----------------------------------------------------------- > > (Updated 十二月 4, 2018, 5:29 p.m.) > > > Review request for oozie, András Piros and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > Auth token cache file name should include Oozie URL, link to oozie-3379. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/AuthOozieClient.java 3a8b5ab6 > core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java > fc9d840b > > core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java > 04fde730 > > > Diff: https://reviews.apache.org/r/69330/diff/4/ > > > Testing > ------- > > I added a test for authOozieClients with the different oozieUrl. > I changed the code for EmbeddedServletContainer. Because this patch needs to > bind the cache file to oozieUrl, you need to test whether multiple different > clients can use the cache. In the original EmbeddedServletContainer code, the > port was random and could not get a given container context path. So the port > binding needs to be added. > > > File Attachments > ---------------- > > oozie-3379-6.patch > > https://reviews.apache.org/media/uploaded/files/2018/11/27/ec465408-bcbc-44bc-a816-7ff73e3c0e68__oozie-3379-6.patch > > > Thanks, > > zhang junfan > >
