[
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741849#comment-16741849
]
Andras Salamon commented on OOZIE-3417:
---------------------------------------
Thanks [~nobigo] for the patch, could you please upload your patch to the
[review board|https://reviews.apache.org/].
> [FS Action] Optimize code about the command about chose fs action
> -----------------------------------------------------------------
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.2.0
> Reporter: duan xiong
> Priority: Major
> Labels: performance
> Attachments: oozie-3417-01.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.
> When judging which logic to use based on commands, should use "switch/case"
> replace "if/else":
> # “if/else” make the code hard to read
> # “if/else” make the code hard to extend
> # “if/else” has low efficience
> So I suggest using “switch/case” instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
