[
https://issues.apache.org/jira/browse/OOZIE-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744806#comment-16744806
]
Andras Salamon commented on OOZIE-3419:
---------------------------------------
After this commit it's no longer possible to compile Oozie without turning off
checkstyle checking:
{noformat}
mvn clean install assembly:single -DskipTests -Dhadoop.version=2.6.0
...
[INFO] --- maven-checkstyle-plugin:2.17:check (default) @ oozie-fluent-job-api
---
[INFO] Starting audit...
/Users/andrassalamon/src/oozie/fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/GraphVisualization.java:9:
error: Line does not match expected header line of ' *'.
Audit done.
[INFO] There is 1 error reported by Checkstyle 6.11.2 with
src/main/resources/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/oozie/fluentjob/api/GraphVisualization.java:[9]
(header) Header: Line does not match expected header line of ' *'.
{noformat}
The
[commit|https://github.com/apache/oozie/commit/96fcb401f81e1aaee3c3de41e77916af95b0e378#diff-65117e05229a1aa9618b6b13c9482667]
changed line 9-11 of {{GraphVisualization.java}} but
[checkstyle-header.txt|https://github.com/apache/oozie/blob/master/fluent-job/fluent-job-api/src/main/resources/checkstyle-header.txt]
of fluent-job still requires the old style.
We should either create an amend commit which changes back the lines to the
style, or we should update checkstyle-header.txt of fluent-job and also update
all the source files to the new style.
> [fluent-job] GraphVisualization fails before JDK 1.8.0_u40
> ----------------------------------------------------------
>
> Key: OOZIE-3419
> URL: https://issues.apache.org/jira/browse/OOZIE-3419
> Project: Oozie
> Issue Type: Improvement
> Components: fluent-job
> Affects Versions: 5.1.0
> Reporter: Andras Piros
> Assignee: Andras Piros
> Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3419.001.patch, OOZIE-3419.002.patch,
> OOZIE-3419.003.patch
>
>
> When {{GraphVisualization.java}} is called e.g. from integration tests / to
> generate {{.png}} or {{.dot}} files to visualize {{Graph}} objects, a
> {{GraphvizException}} occurs when {{JDK1.8.0}} is used before {{u40}}. Let's
> skip execution for these cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
