----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69668/#review212411 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 122 (patched) <https://reviews.apache.org/r/69668/#comment298175> I think using actionConf.getBoolean(OOZIE_ACTION_SQOOP_SHELLSPLITTER, Boolean.FALSE) would be nicer docs/src/site/markdown/DG_SqoopActionExtension.md Lines 97 (patched) <https://reviews.apache.org/r/69668/#comment298176> "By default shell splitter splits the command on every space" - reading this sentence, for me is not obvious that this is the default when oozie.action.sqoop.shellsplitter is swiched on, or this is the general default. It would be good to make it more clear. sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java Lines 115 (patched) <https://reviews.apache.org/r/69668/#comment298177> This constant is already defined in SqoopActionExecutor. Please make it package private and reuse it. - Kinga Marton On Jan. 22, 2019, 10:45 a.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69668/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2019, 10:45 a.m.) > > > Review request for oozie, András Piros, Denes Bodo, Peter Cseh, and Kinga > Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE 2949 - Escape quotes whitespaces in Sqoop <command> field > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/ErrorCode.java e274b9d70 > core/src/main/java/org/apache/oozie/action/hadoop/ShellSplitter.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/action/hadoop/ShellSplitterException.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 556f2cfd1 > core/src/main/resources/oozie-default.xml 6c7fc9ddc > core/src/test/java/org/apache/oozie/action/hadoop/TestShellSplitter.java > PRE-CREATION > docs/src/site/markdown/DG_SqoopActionExtension.md b186c5ab7 > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > edfe0c739 > > > Diff: https://reviews.apache.org/r/69668/diff/3/ > > > Testing > ------- > > Unit tests locally > > > Thanks, > > Andras Salamon > >
