[
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julia Kinga Marton updated OOZIE-3417:
--------------------------------------
Description:
When I read FsActionExecutor.java, I found a not good code in this class. When
judging which logic to use based on commands, should use "switch/case" replace
"if/else":
# “if/else” make the code hard to read
# “if/else” make the code hard to extend
# “if/else” has low efficience
So I suggest using “switch/case” instead.
was:
When I read FsActionExecutor.java, I found a not good code in this class. When
judging which logic to use based on commands, should use "switch/case" replace
"if/else":
# “if/else” make the code hard to read
# “if/else” make the code hard to extend
# “if/else” has low efficience
So I suggest using “switch/case” instead.
Summary: [FS Action] Refactor and optimize FsActionExecutor.java
decision making part (was: [FS Action] Optimize code about the command about
chose fs action)
> [FS Action] Refactor and optimize FsActionExecutor.java decision making part
> ----------------------------------------------------------------------------
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.2.0
> Reporter: duan xiong
> Assignee: duan xiong
> Priority: Major
> Labels: performance
> Attachments: oozie-3417-01.patch, oozie-3417-02.patch,
> oozie-3417-03.patch, oozie-3417-04.patch, oozie-3417-05.patch,
> oozie-3417-06.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.
> When judging which logic to use based on commands, should use "switch/case"
> replace "if/else":
> # “if/else” make the code hard to read
> # “if/else” make the code hard to extend
> # “if/else” has low efficience
> So I suggest using “switch/case” instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
