[ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780382#comment-16780382
 ] 

Andras Salamon commented on OOZIE-3395:
---------------------------------------

[findbugs-diff|https://github.com/AndersDJohnson/findbugs-diff] is not a very 
popular project so cannot assume that we will find it in a central maven 
repository. We should either include the jar, or download it before we the do 
the diff. In the latter case we need to check it of course.

One reason ( mentioned in OOZIE-1986 ) of not including the jar into the Oozie 
project was a licensing issue, this is not longer relevant. I understand that 
it's still not a popular idea. To be honest, storing the md5, hardwiring the 
jar address and downloading the jar again and again does not look much better 
to me.

Maybe we should try to eliminate the findbugs-diff tool. As mention here: 
[https://github.com/spotbugs/discuss/issues/55] spotbugs can create text 
outputs which are much easier to diff. Right now we need a special tool because 
we compare XML reports ( according to OOZIE-1793 that was the only option). 
This should addressed in a separate Jira of course.

> [build] Migration from FindBugs to SpotBugs
> -------------------------------------------
>
>                 Key: OOZIE-3395
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3395
>             Project: Oozie
>          Issue Type: Task
>          Components: build
>            Reporter: Attila Sasvari
>            Assignee: Julia Kinga Marton
>            Priority: Minor
>             Fix For: 5.2.0
>
>         Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch, 
> OOZIE-3395-003.patch, OOZIE-3395-amend-001.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to