[
https://issues.apache.org/jira/browse/OOZIE-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789721#comment-16789721
]
Andras Salamon commented on OOZIE-3446:
---------------------------------------
[~nobigo] Thanks again for the patch, the code modifications looks great to me,
all the direct dependencies have been removed. The test errors reported by
SpotBugs are unrelated, we can ignore those.
I think you could add an extra space to the following line to fix the
formatting:
{noformat}
<commons.lang3.version>3.3.2</commons.lang3.version>
{noformat}
I have a question about the exclusion of the old commons-lang in {{pom.xml}}
and {{core/pom.xml}}: Is it really necessary to exclude the jars in the blocks
similar to this one?
{noformat}
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
<exclusions>
<exclusion>
<artifactId>commons-lang</artifactId>
<groupId>commons-lang</groupId>
</exclusion>
</exclusions>
</dependency>
{noformat}
The two versions of commons-lang can coexist, so I think it's not necessary to
exclude the jars here. Could you please test what happens if we don't exclude
the transitive commons-lang dependencies?
> Migrate from commons-lang 2.x to commons-lang 3.x
> -------------------------------------------------
>
> Key: OOZIE-3446
> URL: https://issues.apache.org/jira/browse/OOZIE-3446
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Andras Salamon
> Assignee: duan xiong
> Priority: Major
> Attachments: OOZIE-3446-001.patch, OOZIE-3446-002.patch
>
>
> Currently Oozie uses both commons-lang 2.x ({{2.4}}) and 3.x ({{3.3.2}}).
> Versions {{2.4}} was released in 2008, {{2.6}} (latest 2.x) was released in
> 2011.
> Although it is possible to use both versions at the same time I think it's
> time to migrate from the legacy 2.x line and use only 3.x (at least directly).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
