[
https://issues.apache.org/jira/browse/OOZIE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803608#comment-16803608
]
duan xiong commented on OOZIE-3454:
-----------------------------------
Hi,[~asalamon74]:(
1. I think we can add printUsage function call after the log_ready_to_start
function.And meanTime we can remove the old printUsage function and replace it
by "WARNNING:Illegal parameters.......can run oozie-setup.sh for help"
2. Maybe we just replace the old sentence with "EXTJS can be downloaded from
Internet".
> Fix oozie-setup.sh usage information
> ------------------------------------
>
> Key: OOZIE-3454
> URL: https://issues.apache.org/jira/browse/OOZIE-3454
> Project: Oozie
> Issue Type: Bug
> Reporter: Andras Salamon
> Assignee: duan xiong
> Priority: Minor
>
> This is the usage information of {{oozie-setup.sh}}:
> {noformat}
> Usage : oozie-setup.sh <Command and OPTIONS>
> sharelib create -fs FS_URI [-locallib SHARED_LIBRARY] [-concurrency
> CONCURRENCY]
> (create
> sharelib for oozie,
> FS_URI is the
> fs.default.name
> for hdfs uri;
> SHARED_LIBRARY, path to the
> Oozie
> sharelib to install, it can be a tarball
> or an
> expanded version of it. If omitted,
> the Oozie
> sharelib tarball from the Oozie
> installation
> directory will be used.
> CONCURRENCY
> is a number of threads to be used
> for copy
> operations.
> By default 1
> thread will be used)
> (action fails
> if sharelib is already installed
> in HDFS)
> sharelib upgrade -fs FS_URI [-locallib SHARED_LIBRARY]
> ([deprecated][use create command to create new version]
> upgrade
> existing sharelib, fails if there
> is no
> existing sharelib installed in HDFS)
> db create|upgrade|postupgrade -run [-sqlfile <FILE>] (create,
> upgrade or postupgrade oozie db with an
> optional sql
> File)
> export <file> exports the
> oozie database to the specified
> file in zip
> format
> import <file> imports the
> oozie database from the zip file
> created by
> export
> (without options prints this usage information)
> EXTJS can be downloaded from http://www.extjs.com/learn/Ext_Version_Archives
> {noformat}
> It sounds logical that without options the script prints of the usage
> information, but this is not true:
> {noformat}
> $ oozie-setup.sh
> INFO: Oozie webconsole disabled, ExtJS library not specified
> INFO: Oozie is ready to be started
> {noformat}
> Checking the source code also shows that in this case it will
> [call|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-setup.sh#L249-L251]
> the prepare_jetty part of the script. It only prints out the usage
> information if we add an invalid option.
> Since calling the script without options is the only way to access the
> prepare_jetty part and we want to keep the script compatible with the earlier
> versions, probably we could just delete this sentence.
> The "EXTJS can be downloaded" part is also obsolete, it cannot be downloaded
> from the link. I'm afraid this version is so old, it cannot be downloaded
> from the official website anymore. This [stackoverflow
> answer|https://stackoverflow.com/a/49298186/21348] suggests to download it
> from the cloudera archive, but I'm not sure if it's a good idea to put that
> link into the opensource Oozie.
> If we fix this, we also need to fix the
> [documentation|https://oozie.apache.org/docs/5.1.0/AG_Install.html], since it
> also contains the usage information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
