[
https://issues.apache.org/jira/browse/OOZIE-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808531#comment-16808531
]
Andras Salamon commented on OOZIE-3461:
---------------------------------------
Thanks [~nobigo] this patch looks great. I think we could clean up the
followings in this class:
* It should be also useful to log the lock acquiring and not only the
releasing ( like in PauseTransitService ).
* Some of the methods have useless {{throws}} in the declaration. For instance
{{materializeCoordJobs}} never throws {{JPAExecutorException}}.
* We could use the diamond operator in several places.
Could you also address these issues? It would also be useful to check the
findbugs/checkbugs output.
> CoordMaterializeTriggerService code cleanup
> -------------------------------------------
>
> Key: OOZIE-3461
> URL: https://issues.apache.org/jira/browse/OOZIE-3461
> Project: Oozie
> Issue Type: Task
> Reporter: Andras Salamon
> Assignee: duan xiong
> Priority: Minor
> Attachments: OOZIE-3461-001.patch
>
>
> It seems to me don't really use the {{delayedCallables}} and {{delay}}
> variables in
> {{CoordMaterializeTriggerService.CoordMaterializeTriggerRunnable}} class. We
> only add items to {{callables}} and not to {{delayedCallables}}. We could
> remove this part of the class.
> It should be also useful to log the lock acquiring and not only the releasing
> ( like in
> [PauseTransitService|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/PauseTransitService.java#L86]
> )
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
