[
https://issues.apache.org/jira/browse/OOZIE-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811440#comment-16811440
]
Hadoop QA commented on OOZIE-3463:
----------------------------------
Testing JIRA OOZIE-3463
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:red}-1{color} the patch contains 5 line(s) longer than 132
characters
. {color:green}+1{color} the patch adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [15] new bugs found below threshold in total
that must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:red}-1{color} There are [15] new bugs found below threshold in
[tools] that must be fixed, listing only the first [5] ones.
. You can find the SpotBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
. The top [5] most important SpotBugs errors are:
. At OozieDBCLI.java:[line 578]: This use of
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL
injection
. At OozieDBCLI.java:[line 568]: At OozieDBCLI.java:[line 567]
. At OozieDBCLI.java:[line 571]: At OozieDBCLI.java:[line 569]
. At OozieDBCLI.java:[line 573]: At OozieDBCLI.java:[line 572]
. At OozieDBCLI.java:[line 578]: At OozieDBCLI.java:[line 575]
. {color:green}+1{color} There are no new bugs found in [core].
. {color:orange}0{color} There are [4] new bugs found in [server] that would
be nice to have fixed.
. You can find the SpotBugs diff here: server/findbugs-new.html
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3169
. {color:orange}Tests failed at first run:{color}
TestBundleChangeXCommand#testBundlePauseExtendMaterializesCoordinator
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1077/
> Migrate from com.google.common.base.Charsets to
> java.nio.charset.StandardCharsets
> ---------------------------------------------------------------------------------
>
> Key: OOZIE-3463
> URL: https://issues.apache.org/jira/browse/OOZIE-3463
> Project: Oozie
> Issue Type: Improvement
> Reporter: Andras Salamon
> Assignee: duan xiong
> Priority: Major
> Attachments: OOZIE-3463-001.patch
>
>
> Oozie uses {{com.google.common.base.Charsets}} in several places. Since Java
> 1.7 it's much easier to use the builtin {{java.nio.charset.StandardCharsets}}
> class as suggested [here|https://stackoverflow.com/a/16066990/21348].
> We should also {{name()}} instead of {{toString()}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
