[
https://issues.apache.org/jira/browse/OOZIE-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837156#comment-16837156
]
Hadoop QA commented on OOZIE-3486:
----------------------------------
Testing JIRA OOZIE-3486
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [3] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:red}-1{color} There are [3] new bugs found below threshold in
[core] that must be fixed.
. You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important SpotBugs errors are:
. At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
. At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
. At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
. java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a
file whose location might be specified by user input: At
BulkJPAExecutor.java:[line 207]
. At AuthorizationService.java:[line 189]: At
AuthorizationService.java:[line 192]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3170
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1107/
> duplicate code in ControlNodeHandler
> ------------------------------------
>
> Key: OOZIE-3486
> URL: https://issues.apache.org/jira/browse/OOZIE-3486
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Minor
> Attachments: OOZIE-3486-01.patch
>
>
> There are duplicate code blocks in ControlNodeHandler and JoinNodeDef classes.
> section of the {{enter}} method of {{ControlNodeHandler:}}
> {noformat}
> ...
> else if (nodeClass.equals(JoinNodeDef.class)) {
> String parentExecutionPath =
> context.getParentExecutionPath(context.getExecutionPath());
> String forkCount = context.getVar(FORK_COUNT_PREFIX +
> parentExecutionPath);
> if (forkCount == null) {
> throw new WorkflowException(ErrorCode.E0720,
> context.getNodeDef().getName());
> }
> int count = Integer.parseInt(forkCount) - 1;
> if (count > 0) {
> context.setVar(FORK_COUNT_PREFIX + parentExecutionPath, "" +
> count);
> context.deleteExecutionPath();
> }
> else {
> context.setVar(FORK_COUNT_PREFIX + parentExecutionPath, null);
> }
> LOG.debug("count = " + count + " for parent execution path " +
> parentExecutionPath);
> doTouch = (count == 0);
> }
> ....{noformat}
> {{enter}} method of {{JoinNodeDef}}:
> {noformat}
> public boolean enter(Context context) throws WorkflowException {
> String parentExecutionPath =
> context.getParentExecutionPath(context.getExecutionPath());
> String forkCount =
> context.getVar(ControlNodeHandler.FORK_COUNT_PREFIX + parentExecutionPath);
> if (forkCount == null) {
> throw new WorkflowException(ErrorCode.E0720,
> context.getNodeDef().getName());
> }
> int count = Integer.parseInt(forkCount) - 1;
> if (count > 0) {
> context.setVar(ControlNodeHandler.FORK_COUNT_PREFIX +
> parentExecutionPath, "" + count);
> context.deleteExecutionPath();
> }
> else {
> context.setVar(ControlNodeHandler.FORK_COUNT_PREFIX +
> parentExecutionPath, null);
> }
> return (count == 0);
> }
> {noformat}
> Similarly one section of {{loopDetection}} can be found in {{JoinNodeDef}},
> one section of {{multiExit}} can be found in {{ForkNodeDef}}.
> We should eliminate the code duplication.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
