----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70635/#review215296 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java Line 54 (original) <https://reviews.apache.org/r/70635/#comment301961> According to the comment this patch removes com.google.common.collect.Lists, but this is the only reference to this class. There are other places where we use the Lists class, mostly for new arraylist creation like Lists.newArrayList. I think it's possible to replace it with Arrays.asList, Collections.singletonList, Collections.emptyList. If we need a mutable list, we might use also new ArrayList<>. core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java Line 1308 (original), 1308 (patched) <https://reviews.apache.org/r/70635/#comment301960> Ouch, we need to use a fully qualified name here. - Andras Salamon On May 13, 2019, 7:42 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70635/ > ----------------------------------------------------------- > > (Updated May 13, 2019, 7:42 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3488 > https://issues.apache.org/jira/browse/OOZIE-3488 > > > Repository: oozie-git > > > Description > ------- > > In Oozie, guava classes are used even when Java 8 already provides a > compatible implementation, removing these usages would reduce the dependency > to guava (which is regularly a headache due to her backward incompatible > changes). > This patch removes: > * com.google.common.base.Function > * com.google.common.collect.Iterables > * com.google.common.collect.Ordering > * com.google.common.collect.Lists > * com.google.common.base.Predicate > * com.google.common.base.Objects > * com.google.common.base.Optional > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 7ebc909a > core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java 88b9ca37 > core/src/main/java/org/apache/oozie/util/db/DatabaseRetryPredicate.java > c89aabe1 > core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java > 9e603ed0 > core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java > 7131e921 > core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java > 5f5d56f6 > core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java > 16a0a827 > > core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java > 1e4413b6 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java > c7f2f498 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > e1960332 > > core/src/test/java/org/apache/oozie/util/db/TestOozieDmlStatementPredicate.java > c2d4b157 > core/src/test/java/org/apache/oozie/util/db/TestOperationRetryHandler.java > c61b1e55 > > core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java > 26dc13ba > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > 6df151cc > > > Diff: https://reviews.apache.org/r/70635/diff/1/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Zsombor Gegesy > >
