----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70762/#review215613 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java Line 74 (original), 77 (patched) <https://reviews.apache.org/r/70762/#comment302362> Please do not use raw types. This would be better: Map<String,String> expectedConfigs = new HashMap<>(); core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java Lines 105 (patched) <https://reviews.apache.org/r/70762/#comment302367> Couldn't we use Map.Entry<String, String> and avoid the toString() methods? core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java Lines 118 (patched) <https://reviews.apache.org/r/70762/#comment302363> Please do not use raw types. core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java Line 192 (original), 135 (patched) <https://reviews.apache.org/r/70762/#comment302364> Please do not use raw types. core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java Lines 149 (patched) <https://reviews.apache.org/r/70762/#comment302365> Please do not use raw types. core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java Line 229 (original), 164 (patched) <https://reviews.apache.org/r/70762/#comment302366> Please do not use raw types. - Andras Salamon On May 31, 2019, 11:28 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70762/ > ----------------------------------------------------------- > > (Updated May 31, 2019, 11:28 a.m.) > > > Review request for oozie and Andras Salamon. > > > Repository: oozie-git > > > Description > ------- > > All the tests from TestLiteWorkflowAppParser, where global configurations are > used are failing because with Java11 the order of the properties is not the > same as with Java8. > > > Diffs > ----- > > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 61e386c43 > > > Diff: https://reviews.apache.org/r/70762/diff/2/ > > > Testing > ------- > > > Thanks, > > Kinga Marton > >
