----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70964/ -----------------------------------------------------------
Review request for oozie and Kinga Marton. Repository: oozie-git Description ------- OOZIE-3513 Migrate from Preconditions.checkNotNull and ParamChecker.notNull Diffs ----- client/src/main/java/org/apache/oozie/client/ApiJarFactory.java bb85d6780 client/src/main/java/org/apache/oozie/client/ApiJarLoader.java 6ecf485ed core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java 376ea1165 core/src/main/java/org/apache/oozie/XException.java fb1a381bb core/src/main/java/org/apache/oozie/action/ActionExecutorException.java 9bc0e81b9 core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java fc4d65b83 core/src/main/java/org/apache/oozie/action/hadoop/HadoopTokenHelper.java 6457cf508 core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java ec45fe495 core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java a509e4d98 core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java 9c45e5392 core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 262a78f5b core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java bc58be6ef core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ab88cac6c core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java d51f0d780 core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java ef0fc2d3e core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 9646d738a core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java 88842f1f1 core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 2f158cdbf core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 2622f05d9 core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java dd8d3d2f6 core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 9ee84063a core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 70b9adc1c core/src/main/java/org/apache/oozie/command/wf/WorkflowNotificationXCommand.java 62bf9b5b3 core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 2761e44b0 core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1d97accd4 core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 42961157a core/src/main/java/org/apache/oozie/executor/jpa/BundleActionGetJPAExecutor.java 3293efd69 core/src/main/java/org/apache/oozie/executor/jpa/BundleActionInsertJPAExecutor.java 4b99c1a59 core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsCountForJobGetJPAExecutor.java c9f3a212d core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetCoordinatorsJPAExecutor.java 2f4665e15 core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java aef9eb79c core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetJPAExecutor.java 7f98cd2a8 core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 6e1ea3e5b core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInsertJPAExecutor.java e7373d67d core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 9e8b33191 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 61614e9fa core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 211d594e5 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 484ff93c9 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 14b831d65 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java c720be99d core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 53214ea64 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionInsertJPAExecutor.java 09e885793 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 8ea31a31d core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsActiveCountJPAExecutor.java 384277a65 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsCountForJobIdJPAExecutor.java f49848f40 core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsPendingFalseCountGetJPAExecutor.java e427835fd core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsPendingFalseStatusCountGetJPAExecutor.java b32ea6e9e core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 49eb15886 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 9a447b03f core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java 2177514e0 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionRunningCountForRangeJPAExecutor.java 34223bb6e core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 4fb7abbad core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java af0c0a3a7 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java b00193128 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 073461f7b core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 9db9daadc core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java c70f0d264 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetJPAExecutor.java 2c21057af core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 3b1cda29c core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 567df40fa core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 4c641d7e8 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInsertJPAExecutor.java c26bc693d core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 6c78bd126 core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java 42505eaee core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java 58f5393a8 core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java 8955419d2 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1c7a14b0e core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionInsertJPAExecutor.java 637f2e083 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 25ad7e232 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 9a8e10321 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 2f012a46e core/src/main/java/org/apache/oozie/executor/jpa/WorkflowIdGetForExternalIdJPAExecutor.java b0c92591c core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 5df684169 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java cd8586ee4 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java 7233bcae7 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetJPAExecutor.java 54350f461 core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobInsertJPAExecutor.java 0816c27de core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java aca79baab core/src/main/java/org/apache/oozie/store/WorkflowStore.java a6b38c59e core/src/main/java/org/apache/oozie/util/ConfigUtils.java 895370a2b core/src/main/java/org/apache/oozie/util/FixedJsonInstanceSerializer.java f319fb9a5 core/src/main/java/org/apache/oozie/util/IOUtils.java 1ee237b16 core/src/main/java/org/apache/oozie/util/JobUtils.java 721a8a0e9 core/src/main/java/org/apache/oozie/util/ParamChecker.java e86971f5d core/src/main/java/org/apache/oozie/util/ParameterVerifier.java ed323a846 core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 365f918dd core/src/main/java/org/apache/oozie/util/PropertiesUtils.java ec0f68725 core/src/main/java/org/apache/oozie/util/XmlUtils.java 41a828127 core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java 53f2c3a6c core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 1e4852d17 core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java fbc1aef50 core/src/main/java/org/apache/oozie/workflow/lite/DecisionNodeDef.java 13a3d8ada core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java 5e6dc7a78 core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 560353c20 core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 2e09889dc core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java b24b84488 core/src/test/java/org/apache/oozie/test/XTestCase.java ed02ff6a3 core/src/test/java/org/apache/oozie/util/TestParamChecker.java 76f2a9c99 core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 15bd99a16 core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java b48e0cc09 examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 9b7bfe41e fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/DecisionConverter.java 7523436a0 fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/ExplicitNodeConverter.java a890def2b fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/GlobalConverter.java dae2655a0 fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/GraphNodesToWORKFLOWAPPConverter.java 00f4c4f2e fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/GraphToWORKFLOWAPPConverter.java b7d99dfc2 server/src/main/java/org/apache/oozie/server/EmbeddedOozieServer.java e2bb7303e server/src/main/java/org/apache/oozie/server/FilterMapper.java b5d59fd11 server/src/main/java/org/apache/oozie/server/HttpConfigurationWrapper.java 0341f9cea server/src/main/java/org/apache/oozie/server/JspHandler.java 6a6fbfa52 server/src/main/java/org/apache/oozie/server/SSLServerConnectorFactory.java aea02a058 server/src/main/java/org/apache/oozie/server/ServletMapper.java e0a135856 sharelib/git/src/main/java/org/apache/oozie/action/hadoop/GitMain.java 692195c26 sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java 751d0e0f7 sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 801a0ae26 sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java bc5f695f2 tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java f91a453c9 tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 6c1195c2f tools/src/main/java/org/apache/oozie/tools/diag/ArgParser.java 115d0ba34 Diff: https://reviews.apache.org/r/70964/diff/1/ Testing ------- Thanks, Andras Salamon
