----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70502/#review216648 -----------------------------------------------------------
docs/src/site/markdown/DG_WorkflowReRun.md Line 5 (original), 5 (patched) <https://reviews.apache.org/r/70502/#comment303850> It is spelled as ReRun later. docs/src/site/markdown/DG_WorkflowReRun.md Line 15 (original), 15 (patched) <https://reviews.apache.org/r/70502/#comment303851> Isn't it called oozie.wf.rerun.failnodes? docs/src/site/markdown/DG_WorkflowReRun.md Lines 16 (patched) <https://reviews.apache.org/r/70502/#comment303853> This is the only place when we use `...`. It would be better to make it consitent and use it always. docs/src/site/markdown/DG_WorkflowReRun.md Lines 27-28 (original), 29-30 (patched) <https://reviews.apache.org/r/70502/#comment303852> What is wfId? Probably the id after -rerun but it's not clear from the documentation. - Andras Salamon On July 15, 2019, 12:14 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70502/ > ----------------------------------------------------------- > > (Updated July 15, 2019, 12:14 p.m.) > > > Review request for oozie and Andras Salamon. > > > Repository: oozie-git > > > Description > ------- > > Currently when you re-run a workflow with property "oozie.wf.rerun.failnodes" > set to true, > > you can no longer re-run it again with "oozie.wf.rerun.skip.nodes" property > specified, even if you set "oozie.wf.rerun.failnodes" to false. > > This kind of limitation is not reasonable. There is only one case where > "oozie.wf.rerun.failnodes" is true and "oozie.wf.rerun.skip.nodes" is not > null or empty, that should be disallowed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/DagEngine.java 70ce96122 > core/src/test/java/org/apache/oozie/TestDagEngine.java 214740574 > core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java > d1d75b50a > docs/src/site/markdown/DG_WorkflowReRun.md c128681a8 > > > Diff: https://reviews.apache.org/r/70502/diff/3/ > > > Testing > ------- > > unit tests added > > > Thanks, > > Kinga Marton > >
