> On July 26, 2019, 4:05 p.m., Andras Salamon wrote: > > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > > Lines 638 (patched) > > <https://reviews.apache.org/r/71168/diff/1/?file=2157981#file2157981line638> > > > > The property name contains the uri scheme, so it will not be possible > > to list all the possible properties in the oozie-default.xml. It means that > > we will get lots of "Invalid configuration defined" warning messages (see > > OOZIE-2338). > > > > Could you modify ConfigurationService.verifyConfigurationName() just > > like in the OOZIE-2338 do ingore the warnings. > > Denes Bodo wrote: > I think this kind of work is out of scope of this fix. Also number of > file systems which shall have custom properties are quite few so in my > opinion defining the options in oozie-default.xml with description will help > the user to set the configuration more easily. > > Andras Salamon wrote: > OK, please open an upstream jira about this limitation, Oozie will print > out warnings if someone wants to set filesystem properties other then s3a and > link it this this jira and also to OOZIE-2338.
https://issues.apache.org/jira/browse/OOZIE-3546 > On July 26, 2019, 4:05 p.m., Andras Salamon wrote: > > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > > Lines 646 (patched) > > <https://reviews.apache.org/r/71168/diff/1/?file=2157981#file2157981line646> > > > > What if a property value contains ","? This solution does not allow > > that. I'm not familiar with the fs properties. Can we safely assume that > > there is no , is the values? > > Denes Bodo wrote: > This is documented now, we will not allow to use comma in property values > nor in property names. > > Andras Salamon wrote: > OK, we can live with this limitation now. Could you please also add a > sentence to the oozie-default.xml description that we don't allow commas in > the property values. > Also please open a new upstream jira which will fix that (no need to > solve the jira in foreseable future but show that we plan to do that). https://issues.apache.org/jira/browse/OOZIE-3547 - Denes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71168/#review216891 ----------------------------------------------------------- On Oct. 1, 2019, 8:09 a.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71168/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2019, 8:09 a.m.) > > > Review request for oozie and Andras Salamon. > > > Bugs: OOZIE-3529 > https://issues.apache.org/jira/browse/OOZIE-3529 > > > Repository: oozie-git > > > Description > ------- > > Many customer who uses s3 file system as secondary one experiences > "UnsupportedOperationException: Accessing local file system is not allowed" > error when Oozie tries to submit the Yarn application. > > > Diffs > ----- > > core/pom.xml d2a211a89 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 0b53a3611 > core/src/main/resources/oozie-default.xml f33c7b938 > core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java > 89ce18550 > core/src/test/java/org/apache/oozie/test/XFsTestCase.java c0f3c6959 > docs/src/site/markdown/AG_HadoopConfiguration.md ab71d7cb6 > > > Diff: https://reviews.apache.org/r/71168/diff/3/ > > > Testing > ------- > > > Thanks, > > Denes Bodo > >
