[
https://issues.apache.org/jira/browse/OOZIE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956854#comment-16956854
]
Hadoop QA commented on OOZIE-3552:
----------------------------------
Testing JIRA OOZIE-3552
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [21] new bugs found below threshold in total
that must be fixed.
. {color:red}-1{color} There are [15] new bugs found below threshold in
[tools] that must be fixed, listing only the first [5] ones.
. You can find the SpotBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
. The top [5] most important SpotBugs errors are:
. At OozieDBCLI.java:[line 584]: This use of
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL
injection
. At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573]
. At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575]
. At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578]
. At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581]
. {color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
. You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The top [5] most important SpotBugs errors are:
. At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
. At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
. At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
. This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
. At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3193
. {color:orange}Tests failed at first run:{color}
TestCoordActionsKillXCommand#testActionKillCommandDate
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1241/
> OozieCLI: missing separator in coordinator job output
> -----------------------------------------------------
>
> Key: OOZIE-3552
> URL: https://issues.apache.org/jira/browse/OOZIE-3552
> Project: Oozie
> Issue Type: Bug
> Components: client
> Reporter: Alexander Litvinov
> Assignee: Alexander Litvinov
> Priority: Major
> Attachments:
> 0001-OOZIE-3552-Missing-delimiter-added-to-coord-job-info.patch
>
>
> In the output, you can see the values for *Nominal Time* and *Status*, that
> there is no separator '\ t' between *2019-10-21 03:00:00 GMTKILLED*
> {code}oozie job -oozie http://oozie.mydomain.ru/oozie -info
> 0207943-190826193438338-oozie-oozi-C -verbose
> {code}
> *output*
> {code}
> Job ID : 0207943-190826193438338-oozie-oozi-C
> ------------------------------------------------------------------------------------------------------------------------------------
> Job Name : my_job
> App Path : /user/bob/oozie/my_job
> Status : KILLED
> Start Time : 2019-10-21 03:00 GMT
> End Time : 2099-10-10 10:00 GMT
> Pause Time : -
> Concurrency : 1
> ------------------------------------------------------------------------------------------------------------------------------------
> ID Action Number Console URL Error Code Error Message
> External ID External Status Job ID Tracker URI Created Nominal Time
> Status Last Modified Missing Dependencies
> ------------------------------------------------------------------------------------------------------------------------------------
> 0207943-190826193438338-oozie-oozi-C@1 1 - - - -
> - 0207943-190826193438338-oozie-oozi-C - 2019-10-21 09:51:55
> GMT 2019-10-21 03:00:00 GMTKILLED 2019-10-21 10:11:26 GMT -
> ------------------------------------------------------------------------------------------------------------------------------------
> {code}
> And in the
> [code|https://github.com/apache/oozie/blob/8002acf772c0a383025d4afb0f70acea2c0c424b/client/src/main/java/org/apache/oozie/cli/OozieCLI.java#L1532]
> you can see the absence of a separator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)