[
https://issues.apache.org/jira/browse/OOZIE-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044476#comment-17044476
]
Junfan Zhang commented on OOZIE-3589:
-------------------------------------
If at least one action is not deleted when reruning, the call function is
required, and it needs to be called only once. So no need to call repeatedly.
Do you think so?
> Wrong using copyActionData method in ReRunXCommand
> ----------------------------------------------------
>
> Key: OOZIE-3589
> URL: https://issues.apache.org/jira/browse/OOZIE-3589
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Junfan Zhang
> Assignee: Junfan Zhang
> Priority: Major
>
> Code is
> [here|https://github.com/apache/oozie/blob/a40ab5361372aa73c9e4aa386a9c81bd21742aa4/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java#L213].
>
> I don't think you should use the {{copyActionData}} method in a {{for}} loop.
> Just call it externally.
> Fixed like:
> {code:java}
> for (int i = 0; i < actions.size(); i++) {
> // Skipping to delete the sub workflow when rerun failed node
> option has been provided. As same
> // action will be used to rerun the job.
> if (!nodesToSkip.contains(actions.get(i).getName()) &&
> !(conf.getBoolean(OozieClient.RERUN_FAIL_NODES, false) &&
>
> SubWorkflowActionExecutor.ACTION_TYPE.equals(actions.get(i).getType()))) {
> deleteList.add(actions.get(i));
> LOG.info("Deleting Action[{0}] for re-run",
> actions.get(i).getId());
> }
> }
> copyActionData(newWfInstance, oldWfInstance);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
