[
https://issues.apache.org/jira/browse/OOZIE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050425#comment-17050425
]
Hadoop QA commented on OOZIE-3584:
----------------------------------
Testing JIRA OOZIE-3584
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [4] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:red}-1{color} There are [3] new bugs found below threshold in
[core] that must be fixed.
. You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important SpotBugs errors are:
. At AuthorizationService.java:[line 192]:
java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file
whose location might be specified by user input
. At AuthorizationService.java:[line 191]: At
AuthorizationService.java:[line 189]
. At ShareLibService.java:[line 695]: Unsafe comparison of hash that are
susceptible to timing attack
. At ShareLibService.java:[line 691]: At ShareLibService.java:[line 689]
. Possible injection that can lead to Source spoofing, header override and
email body injection.: At ShareLibService.java:[line 693]
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:red}-1{color} There are [1] new bugs found below threshold in
[sharelib/oozie] that must be fixed.
. You can find the SpotBugs diff here (look for the red and orange ones):
sharelib/oozie/findbugs-new.html
. The most important SpotBugs errors are:
. At ShellMain.java:[line 93]: This usage of
java/lang/ProcessBuilder.<init>(Ljava/util/List;)V can be vulnerable to
Command Injection
. At ShellMain.java:[line 91]: At ShellMain.java:[line 90]
. At ShellMain.java:[line 92]
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3209
. {color:orange}Tests failed at first run:{color}
TestBlockingInputStream#testFastWritingBlockingInputStream
TestBlockingInputStream#testLimitedWritingBlockingInputStream
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1309/
> Fork-join action issue when action param cannot be resolved
> -----------------------------------------------------------
>
> Key: OOZIE-3584
> URL: https://issues.apache.org/jira/browse/OOZIE-3584
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0
> Reporter: Janos Makai
> Assignee: Janos Makai
> Priority: Major
> Attachments: OOZIE-3584-001.patch, forkjoin_actionparam_issue.log
>
>
> _Current bug_
> *=========*
> There is a sub workflow run in independent mode that runs a fork action which
> contains two (or more) actions.
> These actions inside the fork action run in parallel mode, and they have some
> seconds delay in between them.
> If a parameter is passed to one of these actions, that cannot be resolved,
> then it changes its status to FAILED, and also the workflow’s state to
> FAILED. The other action’s state which are not started yet will stuck in PREP
> state forever. The correct behaviour would be to KILL the remaining actions
> as well as the workflow.
> Note: this bug only occurs when it is run in independent mode. If it has a
> parent workflow, then the parent workflow will kill this workflow after 10
> minutes because of the callback process.
>
> _Log_
> *===*
> 2020-02-14 11:59:26,698 ERROR org.apache.oozie.command.wf.SignalXCommand:
> SERVER[quasar-nqrrjp-4.quasar-nqrrjp.root.hwx.site] USER[admin] GROUP[-]
> TOKEN[] APP[Sub flow fork join] JOB[0000005-200214101441478-oozie-oozi-W]
> ACTION[0000005-200214101441478-oozie-oozi-W@fork-4a1c] Error running forked
> jobs parallely
> org.apache.oozie.command.CommandException: E0718: Workflow already completed
> at
> org.apache.oozie.command.wf.ActionXCommand.failJob(ActionXCommand.java:213)
> at
> org.apache.oozie.command.wf.ActionXCommand.failJob(ActionXCommand.java:185)
> at
> org.apache.oozie.command.wf.SignalXCommand.startForkedActions(SignalXCommand.java:498)
> at
> org.apache.oozie.command.wf.SignalXCommand.execute(SignalXCommand.java:462)
> at org.apache.oozie.command.wf.SignalXCommand.execute(SignalXCommand.java:82)
> at org.apache.oozie.command.XCommand.call(XCommand.java:291)
> at
> org.apache.oozie.command.wf.ActionEndXCommand.execute(ActionEndXCommand.java:283)
> at
> org.apache.oozie.command.wf.ActionEndXCommand.execute(ActionEndXCommand.java:62)
> at org.apache.oozie.command.XCommand.call(XCommand.java:291)
> at
> org.apache.oozie.command.wf.ActionStartXCommand.callActionEnd(ActionStartXCommand.java:352)
> at
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:338)
> at
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:68)
> at org.apache.oozie.command.XCommand.call(XCommand.java:291)
> at
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:363)
> at
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:292)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:210)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.oozie.workflow.WorkflowException: E0718: Workflow
> already completed
> at
> org.apache.oozie.workflow.lite.LiteWorkflowInstance.fail(LiteWorkflowInstance.java:337)
> at
> org.apache.oozie.command.wf.ActionXCommand.failJob(ActionXCommand.java:201)
> ... 19 more
> Full log added as attachment.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
