[
https://issues.apache.org/jira/browse/OOZIE-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460508#comment-17460508
]
Andras Salamon commented on OOZIE-3647:
---------------------------------------
[~zuston] Yes, it's never a good idea to hardwire the default into the code.
A long time ago OOZIE-1890 fixed lots of problems like that (maybe all of that)
but defaults were reintroduced later. I opened a new jira about it later:
OOZIE-3462 but got no progress with that.
I'm not sure which is the best approach. Fix all the things like that in one
step and deprecate the "wrong" methods (too huge patch, maybe we never finish
that). Or do that one by one. What do you think [~dionusos] ?
Seems to me, your patch does not add the default to oozie-default.xml (and we
don't support PRs yet :( )
> Oozie should use the ConfigurationService.getInt instead of
> Services.get().getConf().getInt
> -------------------------------------------------------------------------------------------
>
> Key: OOZIE-3647
> URL: https://issues.apache.org/jira/browse/OOZIE-3647
> Project: Oozie
> Issue Type: Improvement
> Reporter: Junfan Zhang
> Assignee: Junfan Zhang
> Priority: Major
>
> -Now in {{ActionCheckerService}} and {{{}CoordMaterializeTriggerService{}}},
> the callables will be queued using the
> {{{}CallableQueueService.queueSerial{}}}. In the internal implementation of
> {{{}queueSerial{}}}, all callables will be composited as single
> {{{}CompositeCallable{}}}, which means it will be executed in single thread
> serially.-
> -To speed to the execution time, we should set the default number of
> callables in a batch in {{ActionCheckerService}} and
> {{{}CoordMaterializeTriggerService{}}}, like the-
> [-RecoveryService-|https://github.com/apache/oozie/blob/e010fbda91bd78cccb227fc872b3ddd317a5ce6a/core/src/main/java/org/apache/oozie/service/RecoveryService.java#L453]
>
> Oozie should use the {{ConfigurationService.getInt}} instead of
> {{Services.get().getConf().getInt}}, and the default value should be added in
> oozie-default.xml.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
