[ 
https://issues.apache.org/jira/browse/OOZIE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493084#comment-17493084
 ] 

Andras Salamon commented on OOZIE-3658:
---------------------------------------

[~dionusos] I agree that using a random port number could cause problems.

The test is called testConnectionDrop and as far as I understand, it creates a 
BrokerService, stops it, creates a new one. Your patch removes the stopping and 
creating a new one part, so it does not check the drop anymore. Why is that? 
Could we keep this part from the original test?

> Fix TestJMSJobEventListener#testConnectionDrop flakiness (again)
> ----------------------------------------------------------------
>
>                 Key: OOZIE-3658
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3658
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 5.2.1
>            Reporter: Dénes Bodó
>            Assignee: Dénes Bodó
>            Priority: Major
>              Labels: flaky-test, test, unit-test
>         Attachments: OOZIE-3658-001.patch
>
>
> org.apache.oozie.jms.TestJMSJobEventListener#testConnectionDrop fails 
> intermittently due to an unsafe way it allocates system port.
> {code:java}
> int randomPort = 30000 + random.nextInt(10000);
> String brokerURl = "tcp://localhost:" + randomPort;
> ...
> broker.addConnector(brokerURl);{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to