I have submitted a PR to fix this: https://github.com/apache/incubator-opendal/pull/3519
cc @silver, would you like to cancel this vote and start a new one after PR merged (and changelog updated)? On Wed, Nov 8, 2023, at 13:12, Xuanwo wrote: >> This is caused by missing c binding in the **./bindings** directory. >> Although we are only releasing the java/python/nodejs bindings, other >> bindings are still in the root Cargo toml file as workspace members. > > Confirmed. We need to use changed version of `Cargo.toml` to remove not > released packages. > > On Wed, Nov 8, 2023, at 13:03, Xinyou Ji wrote: >> Hi, >> >> When I run the verify script, it shows >> >> ``` >> ./scripts/verify.py >> cargo 1.70.0 (ec8a8a0ca 2023-04-25) >> Start building opendal core >> error: failed to load manifest for workspace member >> `/Users/Ji/Documents/apache/apache-opendal-incubating-0.42.0-src/bindings/c` >> >> Caused by: >> failed to read >> `/Users/Ji/Documents/apache/apache-opendal-incubating-0.42.0-src/bindings/c/Cargo.toml` >> >> Caused by: >> No such file or directory (os error 2) >> Traceback (most recent call last): >> File >> "/Users/Ji/Documents/apache/apache-opendal-incubating-0.42.0-src/./scripts/verify.py", >> >> line 86, in <module> >> main() >> File >> "/Users/Ji/Documents/apache/apache-opendal-incubating-0.42.0-src/./scripts/verify.py", >> >> line 77, in main >> build_core() >> File >> "/Users/Ji/Documents/apache/apache-opendal-incubating-0.42.0-src/./scripts/verify.py", >> >> line 50, in build_core >> subprocess.run(["cargo", "build", "--release"], check=True) >> File >> /opt/homebrew/Cellar/[email protected]/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py<mailto:/opt/homebrew/Cellar/[email protected]/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py>, >> >> line 571, in run >> raise CalledProcessError(retcode, process.args, >> subprocess.CalledProcessError: Command '['cargo', 'build', >> '--release']' returned non-zero exit status 101. >> ``` >> >> This is caused by missing c binding in the **./bindings** directory. >> Although we are only releasing the java/python/nodejs bindings, other >> bindings are still in the root Cargo toml file as workspace members. >> >> Is this expected? `cargo build –release` on this emits the same error. >> >> Best, >> XInyou >> >> From: Mingzhuo Yin <[email protected]> >> Date: Tuesday, November 7, 2023 at 07:20 >> To: [email protected] <[email protected]> >> Subject: [VOTE] Release Apache OpenDAL(incubating) 0.42.0-rc.1 - >> OpenDAL Vote Round 1 >> Hello, Apache OpenDAL(incubating) Community, >> >> This is a call for a vote to release Apache OpenDAL(incubating) version >> 0.42.0. >> >> The tag to be voted on is 0.42.0-rc.1. >> >> The release candidate: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fincubator%2Fopendal%2F0.42.0-rc.1%2F&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FcT8%2F%2FEF2%2B%2FCn9Sninwt1BZJEDImAda01Y4FtXEaEp4%3D&reserved=0<https://dist.apache.org/repos/dist/dev/incubator/opendal/0.42.0-rc.1/> >> >> Keys to verify the release candidate: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.apache.org%2Fincubator%2Fopendal%2FKEYS&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jXZp6rAsSAQinWDVxmxmw7ewJrx%2FnjUkO01mDYOjccs%3D&reserved=0<https://downloads.apache.org/incubator/opendal/KEYS> >> >> Git tag for the release: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-opendal%2Freleases%2Ftag%2Fv0.42.0-rc.1%2F&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m62Aqks2xb9SHSfjQL7sWnpInSAi0w6F04d%2Fji0iGck%3D&reserved=0<https://github.com/apache/incubator-opendal/releases/tag/v0.42.0-rc.1/> >> >> Maven staging repo: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapacheopendal-1016%2F&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ufSaNQdcwwEES%2B3vRa8ITG3iTAGoq7ogg%2F%2FDyjzsfnM%3D&reserved=0<https://repository.apache.org/content/repositories/orgapacheopendal-1016/> >> >> Please download, verify, and test. >> >> The VOTE will be open for at least 72 hours and until the necessary >> number of votes are reached. >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> To learn more about apache opendal, please see >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopendal.apache.org%2F&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VoD36YYWk4Ff10Lys4ImBF6lGG4EVXQTM%2FHHAZ7FTyQ%3D&reserved=0<https://opendal.apache.org/> >> >> Checklist for reference: >> >> [ ] Download links are valid. >> [ ] Checksums and signatures. >> [ ] LICENSE/NOTICE files exist >> [ ] No unexpected binary files >> [ ] All source files have ASF headers >> [ ] Can compile from source >> >> More detailed checklist please refer to: >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-opendal%2Ftree%2Fmain%2Fscripts&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4TY3Hunz02ihymJ1Qfi5mbWaqyvKWe0vNTtGin5CTLg%3D&reserved=0<https://github.com/apache/incubator-opendal/tree/main/scripts> >> >> To compile from source, please refer to: >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-opendal%2Fblob%2Fmain%2FCONTRIBUTING.md&data=05%7C01%7C%7C8450195ce3e84cb4063008dbdf8bed22%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638349564302852326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rEN2E7kvaiPaQ4bu8EBLc89bf2AArPlpVb0ZYoybCW8%3D&reserved=0<https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md> >> >> Here is a Python script in release to help you verify the release candidate: >> >> ./scripts/verify.py >> >> Thanks >> >> Sincerely, >> Mingzhuo Yin > > -- > Xuanwo -- Xuanwo
