After updating the rust on my local env to 1.8, the issue has been resolved.

Correct my -1 to +1.

Sincerely,
Suyan

Xuanwo <[email protected]> 于2024年8月19日周一 18:15写道:

> Failed to reproduce. Which Rust version are you using?
>
> By the way, I personally don't think this is a blocker for the release.
> The Java jars have been built, and all core tests (including services-fs)
> have passed. Would you like to submit an issue for this so we can address
> it outside of this vote thread?
>
> On Mon, Aug 19, 2024, at 18:08, Suyan wrote:
> > I downloaded the latest code and both errors are still there.
> >
> > Maybe you can also have a try?
> > All it needs is `cargo check --features=services-fs`
> >
> > Xuanwo <[email protected]> 于2024年8月19日周一 15:56写道:
> >
> >> Hi, suyan
> >>
> >> > NOTICE file exists in
> >> /tmp/opendla/apache-opendal-bindings-haskell-0.44.9-src
> >> > Start checking LICENSE file in
> >> /tmp/opendla/apache-opendal-bindings-java-0.47.1-src
> >> > LICENSE file exists in
> >> /tmp/opendla/apache-opendal-bindings-java-0.47.1-src
> >> > Start checking NOTICE file in
> >> /tmp/opendla/apache-opendal-bindings-java-0.47.1-src
> >> > NOTICE file exists in
> >> /tmp/opendla/apache-opendal-bindings-java-0.47.1-src
> >> openjdk version "17.0.12" 2024-07-16
> >> OpenJDK Runtime Environment (build 17.0.12+7)
> >> OpenJDK 64-Bit Server VM (build 17.0.12+7, mixed mode, sharing)
> >> Start building opendal java binding
> >> > Success to build opendal java binding
> >>
> >> I can't reproduce your error locally, would you like to double check it?
> >>
> >> On Mon, Aug 19, 2024, at 14:49, Suyan wrote:
> >> > -1
> >> >
> >> > [x] Download links are valid.
> >> > [x] Checksums and signatures.
> >> > [x] LICENSE/NOTICE files exist
> >> > [x] No unexpected binary files
> >> > [x] All source files have ASF headers
> >> > [ ] Can compile from source
> >> > Building java binding failed:
> >> > [INFO] BUILD FAILURE
> >> > [INFO]
> >> >
> ------------------------------------------------------------------------
> >> > [INFO] Total time:  55.036 s
> >> > [INFO] Finished at: 2024-08-19T14:47:19+08:00
> >> > [INFO]
> >> >
> ------------------------------------------------------------------------
> >> > [ERROR] Failed to execute goal
> >> > org.codehaus.mojo:exec-maven-plugin:3.1.0:exec (compile-native-code)
> on
> >> > project opendal: Command execution failed.: Process exited with an
> >> error: 1
> >> > (Exit value: 1) -> [Help 1]
> >> > [ERROR]
> >> >
> >> > --- When running `cargo build` in
> >> > `apache-opendal-bindings-java-0.47.1-src/core/src`'s `core` dir, the
> >> > following errors happened:
> >> > error[E0716]: temporary value dropped while borrowed
> >> >   -->
> >> >
> >>
> /Users/yan/Downloads/opendal-dev/apache-opendal-bindings-java-0.47.1-src/core/src/services/fs/
> >> lister.rs:90
> >> > :14
> >> >    |
> >> > 88 |         let p = if metadata.is_dir() {
> >> >    |             - borrow later stored here
> >> > 89 |             // Make sure we are returning the correct path.
> >> > 90 |             &format!("{rel_path}/")
> >> >    |              ^^^^^^^^^^^^^^^^^^^^^^ creates a temporary value
> >> > which is
> >> > freed while still in use
> >> > 91 |         } else {
> >> >    |         - temporary value is freed at the end of this statement
> >> >    |
> >> >    = note: consider using a `let` binding to create a longer lived
> value
> >> >    = note: this error originates in the macro `format` (in Nightly
> >> > builds,
> >> > run with -Z macro-backtrace for more info)
> >> >
> >> > error[E0716]: temporary value dropped while borrowed
> >> >    -->
> >> >
> >>
> /Users/yan/Downloads/opendal-dev/apache-opendal-bindings-java-0.47.1-src/core/src/services/fs/
> >> lister.rs:142
> >> > :14
> >> >     |
> >> > 140 |         let p = if metadata.is_dir() {
> >> >     |             - borrow later stored here
> >> > 141 |             // Make sure we are returning the correct path.
> >> > 142 |             &format!("{rel_path}/")
> >> >     |              ^^^^^^^^^^^^^^^^^^^^^^ creates a temporary value
> >> > which
> >> > is freed while still in use
> >> > 143 |         } else {
> >> >     |         - temporary value is freed at the end of this statement
> >> >     |
> >> >     = note: consider using a `let` binding to create a longer lived
> >> > value
> >> >     = note: this error originates in the macro `format` (in Nightly
> >> > builds,
> >> > run with -Z macro-backtrace for more info)
> >> >
> >> > For more information about this error, try `rustc --explain E0716`.
> >> > error: could not compile `opendal` (lib) due to 2 previous errors
> >> >
> >> >
> >> > Sincerely,
> >> > Suyan
> >> >
> >> >
> >> > Xuanwo <[email protected]> 于2024年8月15日周四 17:23写道:
> >> >
> >> >> Hello, Apache OpenDAL Community,
> >> >>
> >> >> This is a call for a vote to release Apache OpenDAL version 0.49.1.
> >> >>
> >> >> The tag to be voted on is 0.49.1.
> >> >>
> >> >> The release candidate:
> >> >>
> >> >> https://dist.apache.org/repos/dist/dev/opendal/0.49.1-rc.2/
> >> >>
> >> >> Keys to verify the release candidate:
> >> >>
> >> >> https://downloads.apache.org/opendal/KEYS
> >> >>
> >> >> Git tag for the release:
> >> >>
> >> >> https://github.com/apache/opendal/releases/tag/v0.49.1-rc.2
> >> >>
> >> >> Maven staging repo:
> >> >>
> >> >>
> >>
> https://repository.apache.org/content/repositories/orgapacheopendal-1041/
> >> >>
> >> >> Pypi testing repo:
> >> >>
> >> >> https://test.pypi.org/project/opendal/
> >> >>
> >> >> Website staged:
> >> >>
> >> >> https://opendal-v0-49-1-rc-2.staged.apache.org/
> >> >>
> >> >> Please download, verify, and test.
> >> >>
> >> >> The VOTE will be open for at least 72 hours and until the necessary
> >> >> number of votes are reached.
> >> >>
> >> >> [ ] +1 approve
> >> >> [ ] +0 no opinion
> >> >> [ ] -1 disapprove with the reason
> >> >>
> >> >> To learn more about apache opendal, please see
> >> https://opendal.apache.org/
> >> >>
> >> >> Checklist for reference:
> >> >>
> >> >> [ ] Download links are valid.
> >> >> [ ] Checksums and signatures.
> >> >> [ ] LICENSE/NOTICE files exist
> >> >> [ ] No unexpected binary files
> >> >> [ ] All source files have ASF headers
> >> >> [ ] Can compile from source
> >> >>
> >> >> Use our verify.py to assist in the verify process:
> >> >>
> >> >> svn co https://dist.apache.org/repos/dist/dev/opendal/0.49.1-rc.2/
> >> >> opendal-dev
> >> >>
> >> >> cd opendal-dev
> >> >>
> >> >> curl -sSL
> >> >> https://github.com/apache/opendal/raw/v0.49.1-rc.2/scripts/verify.py
> -o
> >> >> verify.py
> >> >>
> >> >> python verify.py
> >> >>
> >> >> Thanks
> >> >>
> >> >> Xuanwo
> >> >>
> >> >> https://xuanwo.io/
> >> >>
> >>
> >> --
> >> Xuanwo
> >>
> >> https://xuanwo.io/
> >>
>
> --
> Xuanwo
>
> https://xuanwo.io/
>

Reply via email to