You can find a pile of information here (http://www.apache.org/legal/ src-headers.html), but to summarize the code need to contain only the standard apache licence header without any additional copyright notices. Also we don't use @author javadoc tags.

-dain

On Oct 25, 2007, at 2:41 PM, Manu George wrote:

Hi,
       Is the contributed code allowed to contain

Copyright 2007 Jonathan Gallimore
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+

Can someone with more legal knowledge reply to this.

Regards
Manu

On 10/24/07, Jonathan Gallimore <[EMAIL PROTECTED]> wrote:
Whoops! I've attached another patch created with TortoiseSVN, hopefully
that'll do the trick.

The plugin should work with an EJB 2.1 ejb-jar.xml file, I have an old version of the Bank sample (I think its a Geronimo sample) which is EJB 2.1 and that seems to work. I have had some exceptions with openejb-jee
unmarshalling EJB 2.0 xml files though. You do need to have the EJB 3
API classes on your classpath though (although it might be an idea for me to check for that, and add it if its not there already). I think it
would be useful if I put together some documentation and perhaps a
screencam of it in action.

Glad you like the preview - I forgot to mention I had done that.
Essentially its works in the same way as any of the other Java
refactorings. It took a while to figure out how to do it, but was well
worth it, I think ;-)

Cheers

Jon

Manu George wrote:
Hi Jonathan,
                 Sorry for the delay,Can you attach a patch that is
created using svn. The current patch has diffs for the svn specific
files as well. If you create one using svn it will be easier for me to apply too. There was no error in the error logs because I was using an
ejb 2.1 bean :). Once I changed to 3.0 beans it worked like a charm.
The diff view is awesome. Great work Jon

Thanks
Manu

On 10/23/07, Jonathan Gallimore <[EMAIL PROTECTED]> wrote:

Hi Manu,

I have attached a patch to JIRA issue OPENEJB-674. I've have applied the patch to a fresh checkout of the plugin that is already in the sandbox,
and it seemed to work ok, but I had to manually remove the
org.eclipse.jst.server.generic.openejb folder in the root (its now under
the plugins folder). Please let me know if you need anything else.

Also, did you have any luck getting a stack trace from the error log for
the error message you were encountering?

Cheers

Jon


Manu George wrote:

Hey David, hope you are enjoying your vacation. Jonathan, I will be
happy to get this into sandbox. Please attach a patch.

Thanks
Manu








Reply via email to