Hi Manu

Thanks for getting this checked in. It all looks good (thanks for adding the repository too!). I've done a clean checkout and build (after removing my .m2 directory) and the only thing that didn't work was the generation of the update site - The build was successful, but Eclipse complained that the <?xml... line wasn't the first thing in the site.xml file when I tried to install the plugin.

I've attached a patch which has sorted it out on my local copy.

I'll sort out the README tomorrow. I'm also happy to add some documentation to the wiki, if you like, although I'm not sure quite where the best place for the documentation would be?

I've also had a go at a screen cam demonstration of the plugin if anyone's interested (http://www.jrg.me.uk/Projects/OpenEJB.html) - there is sound, but its a bit quiet. I don't know if this sort of thing is useful or appropriate, but I'd be interested to know what people think.

Manu, Many thanks again for doing this, and sorry it wasn't less painful ;-)

Regards

Jon

Hi Jonathan,
                   I have checked in your files into sandbox. Pls have
a look and test it. I am not yet deleting the existing plugin files in
sandbox and will do that once this has been tested.
Also please modify the Readme in sandbox with the additional
instructions and submit a patch when you can.

One other thing that I did was add a repository temporarily to resolve
javax\xml\jsr173\1.0\jsr173-1.0.jar i.e
http://jass.objectweb.org/repository/m2.

Regards
Manu


Index: openejb-eclipse-plugin/assembly/src/main/assembly/site.xml
===================================================================
--- openejb-eclipse-plugin/assembly/src/main/assembly/site.xml	(revision 589855)
+++ openejb-eclipse-plugin/assembly/src/main/assembly/site.xml	(working copy)
@@ -1,3 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
 <!--
   ~ Licensed to the Apache Software Foundation (ASF) under one or more
   ~ contributor license agreements.  See the NOTICE file distributed with
@@ -14,7 +15,6 @@
   ~ See the License for the specific language governing permissions and
   ~ limitations under the License.
   -->
-  <?xml version="1.0" encoding="UTF-8"?>
 <site>
    <feature url="features/org.apache.openejb.feature_1.0.0.jar" id="org.apache.openejb.feature" version="1.0.0">
       <category name="OpenEJB"/>

Reply via email to