On Dec 28, 2007, at 12:30 PM, Jacek Laskowski wrote:
On Dec 28, 2007 9:24 PM, David Blevins <[EMAIL PROTECTED]> wrote:
Do you mind if I fix it real quick then? I think it's just a couple
line change.
Nope. Go and smash the bug so it won't see the light anymore ;-) If
you happen to write a unit test for it, it'd be even better. I enjoyed
reading the techniques with the annotated static classes very much and
would appreciate some more.
Done. Added more to the StatelessInterceptorTest.
FYI, had to yank this part of your last change:
private boolean implies(Method method, String ejbName, Level
level, InterceptorBindingInfo info) {
// do we have parameters?
List<String> params = methodInfo.methodParams;
- if (params == null) return true;
+ if (params == null || params.size() == 0) return true;
If the params are explicitly set as so:
<method>
<method-name>echo</method-name>
<method-params></method-params>
</method>
That maps directly an echo() method and wouldn't apply to an
overloaded method such as echo(String).
-David
