On Jan 5, 2008, at 6:00 PM, Mohammad Nour El-Din wrote:

On Jan 5, 2008 12:50 PM, David Blevins <[EMAIL PROTECTED]> wrote:


On Jan 3, 2008, at 12:29 PM, Dain Sundstrom wrote:

I added code to switch from the OpenEJB http server to Jetty when
the Jetty classes are available.  You can also explicitly state
which http server impl will be chosen by setting the 'impl' property
in the HttpEjbServer properties.

Let me know if you have any problems.  Also, David if you have time
can you review my changes?  I'm not sure it is how you wanted this
to work (I just hacked something quickly).

Cool.  Mohammad had mentioned he was going to work on this[1].
Mohammad how does this compare to what you were thinking of doing?

Well Dain read my mind regarding the configuration property but the new thing is detecting the Jetty classes. I can play with the new code and see
how it runs.



On Feb 18, 2008, at 12:38 PM, Mohammad Nour El-Din wrote:

Embedded Jetty is implemented now, needs some more cleaning but the main
functionality and tests work just fine, please review

Excellent! I poked at it a little and switched OpenEJB back to the default. I also implemented some code that allows ServerServices to have factories. This should allow you to write the actual Jetty detection part; i.e. the part that checks for a jetty class and decides automatically whether to use OpenEJBHttpEjbServer or the new JettyHttpEjbServer you wrote.

You should be able to plumb that right into the HttpServerFactory.createServerService() method.

Once that is done we likely don't need the jetty-httpejbd file anymore. If someone adds jetty to their openejb install, it should just detect it and use it without any need for extra configuration.

-David


-David

[1]
http://www.nabble.com/Re%3A-Webservice-support-in-standalone-OpenEJB-p14478246.html




--
Thanks
- Mohammad Nour

Reply via email to