Hi David,
I've added a patch to the JIRA issue this morning. I've used this to add
annotations to an app I work one for my day job, which only uses session
and message driven beans and it seems to have done a pretty good job.
If you're able to take a look I'd certainly be very grateful, please do
let me know what you think.
I've made some progress in terms of generating annotations for CMP
entity beans, but I would find it particularly useful to have a
discussion about what the best way to go about this is - I think we'll
probably have to look at the CMP class, see what it inherits from and
then change it from an abstract object to an non-abstract one, adding
the right fields to match the getters/setters, and then adding the
annotations.
I've got a bit of a TODO list below, but if there's anything else that
anyone would find useful, please let me know.
Jon
David Blevins wrote:
I keep meaning to get involved here, and I really should as it's not
fair to you having to work off in a corner. As you state, it's far
more motivating to have someone to work with. Tends to lead to
smaller more frequent patches, discussion, and all sorts of goodies :)
If you can submit what you have as a patch I'll take a look at the
whole thing.
-David
On Feb 12, 2008, at 2:12 PM, Jonathan Gallimore wrote:
Hi Daniel,
Many thanks for your email!
That's right, it isn't currently in the official repository, its
currently in the sandbox/openejb-eclipse-plugin area. If you wanted
to team up that would be great - I would certainly find it very
motivating :). I think there's still a bit of work to do before its
ready, the following springs immediately to mind:
* Need to make the server view work with different version strings -
currently it works with openejb-3.0.0-SNAPSHOT but
openejb-3.0.0-beta2 for example didn't work (or at least it didn't
last time I tried)
* Make the PDE tests run during a Maven build (I've made a start on
this, but its not quite there)
* Add annotation generation for Entity beans (again, I've made a
start, I can get the orm.xml file that's generated from
ejb-jar.xml and openejb-jar.xml and passed to OpenJPA, and read it
into the JAXB tree. I think generating most of the annotations for
entity beans will be pretty straightforward from that structure.)
* I think some other refactorings for Entity beans will be needed -
such as making the bean class non-abstract and adding in the
member variables.
I guess the question is what's the best way to proceed - I currently
have some code in my own SVN repo which I ought to create a patch of
and get into the sandbox. I think it would also be useful if pop some
notes on the plugin up on the wiki. What do you think?
Thanks again for your e-mail, I'm looking forward to working with you
and making progress with the plugin!
Cheers
Jon
Daniel S. Haischt wrote:
Hi there,
is it right that your Eclipse plugin isn't part of the official
OpenEJB SVN repo? If yes, has it been discussed on the ML to get
the code into the OpenEJB repository?
Maybe if you need some help to get the plugin into the OpenEJB
repository we could team up to make it happen...
What do you think?
Cheers
Daniel S. Haischt