Rick, fantastic to see some javadoc in that code!!! Very excellent.
On Jun 17, 2008, at 8:43 AM, [EMAIL PROTECTED] wrote:
Author: rickmcguire
Date: Tue Jun 17 08:43:37 2008
New Revision: 668715
- if (conversion == null) throw new
NullPointerException("unsupported conversion for EJB select return
type " + to.getName());
+ {
+ if (conversion == null)
+ throw new NullPointerException("unsupported
conversion for EJB select return type " + to.getName());
+ }
FYI, you might want to check your editor's settings. Weird use of
braces there.
- if (!ejbCreate.getName().startsWith("ejbCreate"))
continue;
+ if (!ejbCreate.getName().startsWith("ejbCreate"))
+ {
+ continue;
+ }
Single line ifs are fine. Splitting them with braces is fine too.
FYI, make sure you follow the brace format of the rest of the code
though.
Overall, a quite impressive 268 lines of new javadoc + comments.
About 260 more lines than before :)
-David
