I don't remember fixing this specifically, but I may have fixed is
while working on something else. Can you check that it is working
properly again?
Thanks,
-dain
On Sep 1, 2008, at 7:42 AM, Monteiro Jean-Louis wrote:
Hi again,
Seems like fixed in the trunk (Thanks Dain).
Can it be closed ?
Regards,
Jean-Louis
-----Message d'origine-----
De : Jean-Louis MONTEIRO (JIRA) [mailto:[EMAIL PROTECTED]
Envoyé : vendredi 25 juillet 2008 12:14
À : Monteiro Jean-Louis
Objet : [jira] Updated: (OPENEJB-851) ActiveMQResourceAdapter:
ActiveMQ Embedded broker always started even if BrokerXmlConfig is
empty
[ https://issues.apache.org/jira/browse/OPENEJB-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Louis MONTEIRO updated OPENEJB-851:
----------------------------------------
Summary: ActiveMQResourceAdapter: ActiveMQ Embedded broker always
started even if BrokerXmlConfig is empty (was:
ActiveMQResourceAdapter: unable to connect to a remote broker)
ActiveMQResourceAdapter: ActiveMQ Embedded broker always started
even if BrokerXmlConfig is empty
-------------------------------------------------------------------------------------------------
Key: OPENEJB-851
URL: https://issues.apache.org/jira/browse/OPENEJB-851
Project: OpenEJB
Issue Type: Bug
Components: container system
Affects Versions: 3.0.1
Environment: XP
Reporter: Jean-Louis MONTEIRO
Using Embedded ActiveMQBroker works fine.
But, I'm facing a problem to connect to a remote broker using the
JMS Resource Adapter (ActiveMQResourceAdapter).
As far as I have understood, the configuration should be:
<Resource id="My JMS Resource Adapter"
type="ActiveMQResourceAdapter">
# Broker configuration URI as defined by ActiveMQ
# see http://activemq.apache.org/broker-configuration-uri.html
#BrokerXmlConfig broker:(tcp://localhost:61616)?useJmx=false
BrokerXmlConfig
# Broker address
#ServerUrl vm://localhost?async=true
ServerUrl tcp://<target IP address>:61616
# DataSource for persistence messages
DataSource My Unmanaged DataSource
</Resource>
But, before delegating to the super class (ActiveMQ), openejb adds
a "openejb:" prefix to the empty URI.
Looking to the super class
(org.apache.activemq.ra.ActiveMQResourceAdapter.start()) helps me
suggesting a patch:
Index: D:/javatools/openEJB3/openejb3-src/container/openejb-core/
src/main/java/org/apache/openejb/resource/activemq/
ActiveMQResourceAdapter.java
===================================================================
--- D:/javatools/openEJB3/openejb3-src/container/openejb-core/src/
main/java/org/apache/openejb/resource/activemq/
ActiveMQResourceAdapter.java (revision 674174)
+++ D:/javatools/openEJB3/openejb3-src/container/openejb-core/src/
main/java/org/apache/openejb/resource/activemq/
ActiveMQResourceAdapter.java (working copy)
@@ -115,7 +115,7 @@
// prefix server uri with openejb: so our broker factory is
used
String brokerXmlConfig = getBrokerXmlConfig();
- if (brokerXmlConfig != null) {
+ if (brokerXmlConfig!=null &&
brokerXmlConfig.trim().length()>0 ) {
try {
URISupport.CompositeData compositeData =
URISupport.parseComposite(new URI(brokerXmlConfig));
compositeData.getParameters().put("persistent",
"false");
Best regards,
Jean-Louis MONTEIRO
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Ce message et les pièces jointes sont confidentiels et réservés à
l'usage exclusif de ses destinataires. Il peut également être
protégé par le secret professionnel. Si vous recevez ce message par
erreur, merci d'en avertir immédiatement l'expéditeur et de le
détruire. L'intégrité du message ne pouvant être assurée sur
Internet, la responsabilité du groupe Atos Origin ne pourra être
recherchée quant au contenu de ce message. Bien que les meilleurs
efforts soient faits pour maintenir cette transmission exempte de
tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa
responsabilité ne saurait être recherchée pour tout dommage
résultant d'un virus transmis.
This e-mail and the documents attached are confidential and intended
solely for the addressee; it may also be privileged. If you receive
this e-mail in error, please notify the sender immediately and
destroy it. As its integrity cannot be secured on the Internet, the
Atos Origin group liability cannot be triggered for the message
content. Although the sender endeavours to maintain a computer virus-
free network, the sender does not warrant that this transmission is
virus-free and will not be liable for any damages resulting from any
virus transmitted.
