David Blevins kirjoitti:
On Oct 16, 2008, at 7:23 AM, Alex Grönholm wrote:
I just have to say that this class (among some others) is a mess.
It's a mish-mash of fields and methods here and there with little to
no documentation or organization. I think some kind of mutually
agreed coding standards would certainly help hold this project
together and decrease the learning curve for newbies (such as myself).
You're definitely welcome to do some reformatting. We have a general
guideline on the project of not including functional changes with
major reformatting as it makes it really really hard to spot the real
change amongst the other more cosmetic changes. So if you feel like
doing any reformatting, definitely submit that as a separate patch.
-David
What I'm saying is that we need a written set of guidelines so that
freshly contributed code wouldn't have to be constantly reformatted. A
good sized set of example code files would go a long way towards this
goal. If you agree with me on this, we could set up a Wiki page for
contributors where all the necessary instructions and guidelines would go.
