Fredrik,

This is an awesome patch. Thank you very much!
Have committed your patch.

On Mon, Mar 9, 2009 at 6:21 PM, Fredrik Jonson <[email protected]>wrote:

> Hi,
>
> I hope the following patch solves a bit of your problem. It changes
> the dependency plugin configuration to copy the artifacts to the
> target path instead of the source path. Secondly it uses the
> destFileName parameter to make the final name of the copied artifacts
> versionless.
>
> I also think you can solve the version number issue by declaring a
> parent pom in the project and then use ${project.parent.version}
> instead of the fixed 3.1 in both the dependency and the dependency
> plugin sections. Not too confident to what extent that option is
> what you want though, so I've left that out here...
>
> Index: examples/webapps/applet/src/main/webapp/index.jsp
> ===================================================================
> --- examples/webapps/applet/src/main/webapp/index.jsp   (revision 751861)
> +++ examples/webapps/applet/src/main/webapp/index.jsp   (working copy)
> @@ -19,7 +19,7 @@
>  <body>
>  <applet alt="could not load applet" height="100" width="300"
>        codebase="."
> -       archive="app.jar,javaee-api-5.0-1.jar,openejb-client-3.1.jar"
> +       archive="app.jar,javaee-api.jar,openejb-client.jar"
>        code="org.superbiz.applet.CalculatorApplet">
>  </applet>
>  </body>
> Index: examples/webapps/applet/pom.xml
> ===================================================================
> --- examples/webapps/applet/pom.xml     (revision 751861)
> +++ examples/webapps/applet/pom.xml     (working copy)
> @@ -79,10 +79,10 @@
>             </goals>
>             <configuration>
>               <tasks>
> -                <jar destfile="src/main/webapp/app.jar"
> basedir="target/classes"/>
> -                <signjar jar='src/main/webapp/app.jar' alias="mykey"
> storepass="openejb"/>
> -                <signjar jar='src/main/webapp/openejb-client-3.1.jar'
> alias="mykey" storepass="openejb"/>
> -                <signjar jar='src/main/webapp/javaee-api-5.0-1.jar'
> alias="mykey" storepass="openejb"/>
> +                <jar
> destfile="${project.build.directory}/${project.build.finalName}/app.jar"
> basedir="target/classes"/>
> +                <signjar
> jar="${project.build.directory}/${project.build.finalName}/app.jar"
> alias="mykey" storepass="openejb"/>
> +                <signjar
> jar="${project.build.directory}/${project.build.finalName}/openejb-client.jar"
> alias="mykey" storepass="openejb"/>
> +                <signjar
> jar="${project.build.directory}/${project.build.finalName}/javaee-api.jar"
> alias="mykey" storepass="openejb"/>
>               </tasks>
>             </configuration>
>           </execution>
> @@ -104,13 +104,15 @@
>                   <groupId>org.apache.openejb</groupId>
>                   <artifactId>openejb-client</artifactId>
>                   <version>3.1</version>
> -                  <outputDirectory>src/main/webapp</outputDirectory>
> +
>  
> <outputDirectory>${project.build.directory}/${project.build.finalName}</outputDirectory>
> +                  <destFileName>openejb-client.jar</destFileName>
>                 </artifactItem>
>                 <artifactItem>
>                   <groupId>org.apache.openejb</groupId>
>                   <artifactId>javaee-api</artifactId>
>                   <version>5.0-1</version>
> -                  <outputDirectory>src/main/webapp</outputDirectory>
> +
>  
> <outputDirectory>${project.build.directory}/${project.build.finalName}</outputDirectory>
> +                  <destFileName>javaee-api.jar</destFileName>
>                 </artifactItem>
>               </artifactItems>
>             </configuration>
>
> --
> Fredrik Jonson
>
>


-- 
Karan Singh Malhi

Reply via email to