You're right the TODO's are still there, sorry about that, I was way too tired when I wrote that last night. I'll get the patch in this evening.
Jon On Thu, Apr 23, 2009 at 8:09 AM, Jean-Louis MONTEIRO < [email protected]> wrote: > > Thanks for the reply. > > > Jonathan Gallimore-2 wrote: > > > > The basic stuff I did (supporting basic auth, and simple > username/password > > WS-Security) is there in trunk, and seems to be working to me. It seems > to > > honour the @RolesAllowed too. > > > Yea, nice feature. > > > Jonathan Gallimore-2 wrote: > > > > I did apply the patch you provided previously to my working copy and it > > looked good - this one attached to the JIRA looks like a more up to date > > version of the same patch - is that right? > > > Yes, I've done some enhancements and some piece of code has be re factored. > > > Jonathan Gallimore-2 wrote: > > > > I notice that your new patch removes the TODOs discussed in this thread a > > couple of days ago, is that intentional? > > > If you are talking about TODOs added by David, they are still in the patch > (AppInfoBuilder.configureWebserviceScurity(List<PortInfo> infoList, Object > altDD) { > ) > > > Jonathan Gallimore-2 wrote: > > > > Apart from that, my quick glance at this patch looks good, I'll give it a > > proper test and try and get it committed for you tomorrow. > > > > Thanks again. > Jean-Louis > -- > View this message in context: > http://www.nabble.com/Re%3A-Securing-a-webservice-tp22265166p23191481.html > Sent from the OpenEJB Dev mailing list archive at Nabble.com. > >
