Looks good to me.
-David
On Aug 4, 2009, at 3:07 PM, Jonathan Gallimore wrote:
I've had a look at this, and it looks like we look at all the files
in the
webapps folder when running in Tomcat. I've made this really simple
patch
which will ignore any files starting with a dot:
Can I just check I haven't missed an obvious setting before I commit
this?
Cheers
Jon
jgallim...@desktop:~/Sync/OpenEJB/src/openejb3$ svn diff
Index:
assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/
apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java
===================================================================
---
assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/
apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java
(revision 800924)
+++
assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/
apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java
(working copy)
@@ -449,6 +449,11 @@
String name = file.getName();
// ignore war files
if (name.toLowerCase().endsWith(".war") ||
name.equals("ROOT") || name.equalsIgnoreCase("META-INF") ||
name.equalsIgnoreCase("WEB-INF")) continue;
+ // ignore files beginning with a .
+ if (name.startsWith(".")) {
+ logger.info("Ignoring file: " + name);
+ continue;
+ }
// ignore unpacked web apps
if (file.isDirectory() && new File(file,
"WEB-INF").exists()) continue;
// ignore unpacked apps where packed version is
present
(packed version is owner)
On Tue, Aug 4, 2009 at 2:10 PM, Jonathan Gallimore <
[email protected]> wrote:
Hi Riaz,
Off the top of my head, I'm not aware of a setting that would do
this when
running in Tomcat mode - we do have a
openejb.deployments.classpath.exclude
property when running OpenEJB in an embedded manner. I'll have a go
and see
if there is some setting that will do this in Tomcat. If there
isn't, I'm
sure we can add something (I think ignoring anything that starts
with a .
would be a good idea).
Jon
On Sun, Aug 2, 2009 at 9:17 PM, riazb <[email protected]> wrote:
Hello,
Is there a way to make OpenEJB3 not constantly try to
initialize .DS_Store
within webapps (or wherever) and throwing a repeated error which
is making
my Eclipse console eternally long with pointless errors.
The error is:
Error deploying application /Developer/Tomcat/webapps/.DS_Store
org.apache.openejb.config.UnknownModuleTypeException: Unable to
determine
module type for jar: file:/Developer/Tomcat/webapps/.DS_Store:
Unknown
module type: url=file:/Developer/Tomcat/webapps/.DS_Store
at
org
.apache.openejb.config.DeploymentLoader.load(DeploymentLoader.java:
122)
at
org
.apache
.openejb
.tomcat
.catalina.TomcatWebAppBuilder.checkHost(TomcatWebAppBuilder.java:
467)
at
org
.apache
.openejb
.tomcat
.catalina
.GlobalListenerSupport.lifecycleEvent(GlobalListenerSupport.java:74)
at
org
.apache
.catalina
.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:117)
at
org
.apache
.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:
1337)
at
org.apache.catalina.core.ContainerBase
$ContainerBackgroundProcessor.processChildren(ContainerBase.java:
1601)
at
org.apache.catalina.core.ContainerBase
$ContainerBackgroundProcessor.processChildren(ContainerBase.java:
1610)
at
org.apache.catalina.core.ContainerBase
$ContainerBackgroundProcessor.run(ContainerBase.java:1590)
at java.lang.Thread.run(Thread.java:637)
Caused by: org.apache.openejb.config.UnknownModuleTypeException:
Unknown
module type: url=file:/Developer/Tomcat/webapps/.DS_Store
at
org
.apache
.openejb
.config.DeploymentLoader.discoverModuleType(DeploymentLoader.java:
1176)
at
org
.apache.openejb.config.DeploymentLoader.load(DeploymentLoader.java:
120)
According to Mac forums, .DS_Store cannot be disable on a local
drive.
I googled around and found out that on the Geronimo task list,
there was
mention of 'Ignore .DS_Store when scanning'.
Anything similar in OpenEJB? thanks
Riaz
--
View this message in context:
http://www.nabble.com/.DS_Store-annoyance-on-the-Mac-tp24781677p24781677.html
Sent from the OpenEJB User mailing list archive at Nabble.com.
