Hi I hope I am not too late but I will not be able to do anything until tomorrow night 14-October-2009 and I will put your comments into consideration.
On Tue, Oct 13, 2009 at 9:57 PM, Kevan Miller <[email protected]> wrote: > > On Oct 13, 2009, at 2:46 PM, David Blevins wrote: > >> >> On Oct 13, 2009, at 9:51 AM, Kevan Miller wrote: >> >>> The NOTICE file copyright date is 2008. It should be 2009. >> >> Thought I got those. Feel free to update it or post the file path and >> I'll update it. > > http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/NOTICE and > examples/NOTICE.txt (I didn't check to see if this is actually used in > generated examples). > >> >>> !????? ./examples/webapps/moviefun/src/main/webapp/default.css >>> !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp >>> !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp >> >> These three should probably have license headers. We can also add them to >> the jaxb generated classes though it isn't necessary. The rest have been >> flagged and excluded several times. > > K. I'd agree with those 3. See the others that I posted in response to > Jonathan. Agreed that jaxb classes don't need them. Not sure how the files > others are being excluded... I tried to look back for past votes, but prolly > looked in the wrong place. > > --kevan > -- Thanks - Mohammad Nour - LinkedIn: http://www.linkedin.com/in/mnour ---- "Life is like riding a bicycle. To keep your balance you must keep moving" - Albert Einstein "Writing clean code is what you must do in order to call yourself a professional. There is no reasonable excuse for doing anything less than your best." - Clean Code: A Handbook of Agile Software Craftsmanship
